From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <hornschnorter@gmail.com>
cc: Thomas Munro <thomas.munro@enterprisedb.com>,
        Andres Freund <andres@anarazel.de>,
        Pg Hackers <pgsql-hackers@postgresql.org>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes
In-reply-to: <25938.1487367117@sss.pgh.pa.us>
References: <20170217181348.a5pnflupslw2t6xx@alvherre.pgsql>
 <32279.1487355685@sss.pgh.pa.us> <2664.1487360457@sss.pgh.pa.us>
 <0C821A10-45A2-4112-A1A2-EDAE27712C62@anarazel.de>
 <16461.1487361849@sss.pgh.pa.us>
 <CAEepm=1wVjmuPCdtgyn7-huNFAabhu4b7VwoRpCcVtQ7C=ScTw@mail.gmail.com>
 <19678.1487362865@sss.pgh.pa.us>
 <B9FB1155-B39D-43C9-A7E6-B67E1C59E4CE@gmail.com>
 <25938.1487367117@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 17 Feb 2017 16:31:57 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30006.1487374499.1@sss.pgh.pa.us>
Date: Fri, 17 Feb 2017 18:34:59 -0500
Message-ID: <30007.1487374499@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

I wrote:
> Right now I'd rather focus on getting to where we can have -Werror on in
> the buildfarm at all.  longfin says we've got work to do on that, at least
> in the back branches.  It may be that we can't expect near-EOL branches to
> always compile perfectly cleanly on newer compilers.

I found that longfin's compiler is happy with 9.4 and up as-is, and it
required only a few very small and safe back-patches to make 9.3 work
too.  However, it's looking like -Werror with 9.2 is a bridge too far.
The thing that seems untenable is that to make 9.2 compile clean, we would
have to back-patch commit 71450d7fd, along with a fair amount of follow-on
work, so that the compiler would understand that ereport(ERROR) doesn't
return.  I don't think we want to go that far --- and maybe introduce
portability issues for someone's ancient compiler --- for a branch that's
near EOL anyway.

I'll adjust longfin's configuration so that it only applies -Werror in
9.3 and up.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers