From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Nitin Jadhav <nitinjadhavpostgres@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Michael Paquier <michael@paquier.xyz>,
        Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
        Andres Freund <andres@anarazel.de>,
 Stephen Frost <sfrost@snowman.net>,
        Magnus Hagander <magnus@hagander.net>,
        Thomas Munro <thomas.munro@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: when the startup process doesn't (logging startup delays)
In-reply-to: 
 <CA+TgmoZ3ZXqBQ1WSEn-Vo0+8V-8eAUO-fJcCmVUQ54Ecc6zNPQ@mail.gmail.com>
References: <202109291749.ejyaab7wazx7@alvherre.pgsql>
 <2992585.1632938816@sss.pgh.pa.us>
 <CA+TgmoZ3ZXqBQ1WSEn-Vo0+8V-8eAUO-fJcCmVUQ54Ecc6zNPQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 29 Sep 2021 16:59:09 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3002162.1632949965.1@sss.pgh.pa.us>
Date: Wed, 29 Sep 2021 17:12:45 -0400
Message-ID: <3002163.1632949965@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3002163.1632949965%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Sep 29, 2021 at 2:06 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The real comment I'd have here, though, is that writing one-off
>> code for this purpose is bad.  If we have a need for a repetitive
>> timeout, it'd be better to add the feature to timeout.c explicitly.
>> That would probably also remove the need for extra copies of the
>> timeout time.

> I'm not sure that really helps very much, honestly.

I didn't claim there are any other places that could use the feature
*today*.  But once we've got one, it seems like there could be more
tomorrow.  In any case, I dislike keeping timeout state data outside
timeout.c, because it's so likely to get out-of-sync that way.

			regards, tom lane