Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5xUi-0003o2-BZ for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jul 2021 21:41:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m5xUg-0007D8-7A for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jul 2021 21:41:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5xUf-0007D0-DH for pgsql-hackers@lists.postgresql.org; Tue, 20 Jul 2021 21:41:37 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m5xUU-0000gZ-Cj for pgsql-hackers@lists.postgresql.org; Tue, 20 Jul 2021 21:41:36 +0000 Received: by mail-wm1-x331.google.com with SMTP id c17so174324wmb.5 for ; Tue, 20 Jul 2021 14:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=ze4vxLoGoYluR94+JwUG9ql/kTHiAxjaihzPwauwRbc=; b=F/Uf0IFL3xhsEIkFAFJmmzhfc+wiq5ipeSMQ9MSy4dpCkq6cnfBqJG3rIpHdmfvWuZ 41gHldzFpPcnCuShXZp0y31+QlIocAMFbYAMDreUOuFShelh7PZCT9uEnIdgN9qnG9lT nQAUAqZGmlQk+PIufC9IMUuk2ES+N2KIaYdstH4y+QAoPEcrRkwoY6YLMMODLE/FI2W/ gtnxTO2AVX/tSJ3RVnRorP8HZLUxQIMG1dWXcDnBaZ3daQiOIMQD2mnlr1nlHO76eeYi v+EMip8OmGutb0qEJmuWVYSHIWMBpZkRD7dy+iAwvqebkXEFeA0rWcb8Rx+sh/oAb3cF 90Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=ze4vxLoGoYluR94+JwUG9ql/kTHiAxjaihzPwauwRbc=; b=YCMQYhw3tCoo/+DywspbGoj97BufbSk5SKbTQAsy0tWhZnQJoYOzjq2oUa+0Ex2d4e j05TKl79INh+9u3yXvb99cWtF038rY2sEoeV/uJ8ryNB6VKgtTt1HZVhu4x6sFILfTSM PhdEBB23osF1P79YKb8fjxFO41A1gBmlwdipTBZ5nTNrNU9tEle2s6UtHcal/yDSsQ7B gEuK9swyXP7EpoKJ0MYGM7WztIKTYoDnpA5asqlSTgKnq/YWuJb1Mfp9G3HJlEIuzAzu kmHZJ56w8lzAcN+KdVBqF5FDdCkB4bx+9bb/n+Rl/uAhON4wxfl8HqeisPfx+5Ndnpcz +IlQ== X-Gm-Message-State: AOAM532jjDbvVaC+5LkgzJ3KrTmsz4hQOrGWT4/YbcGaUaVvSKBbIgLU XA+9IHqwxqk+AUi/h2TCUitJPuqqLmT+wRIJcvjG4bFN46D5re+CaaAzDFu2ALgf0eB7cAJHQ65 9Kh7ZFlIIY7pf2ZgAedhIeTYgc9Bpa+pVqqLgJq1ThjjuLrGKT4ZUfw4hfUZ5KxYqdCTWVZBya+ RyuCQAd/0+juqBv0bxdRx7NERYgABlS+45GSrkKP7KJiBZQaDsIsP1 X-Google-Smtp-Source: ABdhPJzxx2bU5YwdmY5bhYFYS9oQgbOTR997E9Tfcc3TlQDmheMurFOCPVmc3SBzt0DXNG1cfp25lw== X-Received: by 2002:a05:600c:24f:: with SMTP id 15mr33881008wmj.123.1626817284638; Tue, 20 Jul 2021 14:41:24 -0700 (PDT) Received: from [10.137.0.19] (ip-86-49-254-183.net.upcbroadband.cz. [86.49.254.183]) by smtp.gmail.com with ESMTPSA id j2sm3284864wrp.90.2021.07.20.14.41.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jul 2021 14:41:23 -0700 (PDT) Subject: Re: logical decoding and replication of sequences To: vignesh C Cc: PostgreSQL Hackers , Petr Jelinek References: <377c6fda-c3eb-7a69-e981-c77ae459c5db@enterprisedb.com> <5105c3ad-d726-fc22-1d09-514b6852a15e@enterprisedb.com> From: Tomas Vondra Message-ID: <3005299b-267d-8e4a-68a3-abdad3e96aba@enterprisedb.com> Date: Tue, 20 Jul 2021 23:41:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------F9EB02B1DC68684AA328B96B" Content-Language: en-US X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------F9EB02B1DC68684AA328B96B Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Here's a rebased version of the patch, no other changes. I think the crucial aspect of this that needs discussion/feedback the most is the transactional vs. non-transactional behavior. All the other questions are less important / cosmetic. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --------------F9EB02B1DC68684AA328B96B Content-Type: text/x-patch; charset=UTF-8; name="0001-Logical-decoding-replication-of-sequences-20210720.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Logical-decoding-replication-of-sequences-20210720.patc"; filename*1="h"