From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        "Bossart,
    Nathan" <bossartn@amazon.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        "andres@anarazel.de" <andres@anarazel.de>,
        "masao.fujii@oss.nttdata.com" <masao.fujii@oss.nttdata.com>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>,
        "mengjuan.cmj@alibaba-inc.com" <mengjuan.cmj@alibaba-inc.com>,
        "Jakub.Wartak@tomtom.com" <Jakub.Wartak@tomtom.com>,
        Ryo Matsumura <matsumura.ryo@fujitsu.com>
Subject: Re: prevent immature WAL streaming
In-reply-to: <41423ae2-eceb-16d6-0ee3-11abc3a5c50f@dunslane.net>
References: <202109292127.7q66qhxhde67@alvherre.pgsql>
 <41423ae2-eceb-16d6-0ee3-11abc3a5c50f@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Wed, 29 Sep 2021 17:40:47 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3006957.1632955712.1@sss.pgh.pa.us>
Date: Wed, 29 Sep 2021 18:48:32 -0400
Message-ID: <3006958.1632955712@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3006958.1632955712%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 9/29/21 5:27 PM, Alvaro Herrera wrote:
>> So, do we take the stance that we have no right to expect pg_basebackup
>> to work if we didn't pass allow_streaming => 1?  If so, the fix is to
>> add it.  But my preferred fix would be to call set_replication_conf if
>> either allows_streaming or has_archiving are given.
>> 
>> Another easy fix would be to call $primary2->set_replication_conf in the
>> test file, but then you'd complain that that's supposed to be an
>> internal method :-)

> It claims that but it's also used here:
> src/bin/pg_basebackup/t/010_pg_basebackup.pl

Given that precedent, it seems like calling set_replication_conf
is a good quick-fix for getting the buildfarm green again.
But +1 for then refactoring this to get rid of these hacks (both
with respect to pg_hba.conf and the postgresql.conf parameters)
in both of these tests.

			regards, tom lane