Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M305792=pgsql-hackers-arkari@postgresql.org>)
	id 1bhjF4-0001oV-1s
	for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 20:14:42 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M305792=pgsql-hackers-arkari@postgresql.org>)
	id 1bhjF3-0003ET-L5
	for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 20:14:41 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1bhjF2-0003B2-2H
	for pgsql-hackers@postgresql.org; Wed, 07 Sep 2016 20:14:40 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1bhjEz-0008Qu-1k
	for pgsql-hackers@postgresql.org; Wed, 07 Sep 2016 20:14:39 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u87KEIB1030074;
	Wed, 7 Sep 2016 16:14:18 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
cc: emre@hasegeli.com, Andrew Dunstan <andrew@dunslane.net>,
        Robert Haas <robertmhaas@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Matthias Kurz <m.kurz@irregular.at>,
        Jim Nasby <Jim.Nasby@bluetreble.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>
Subject: Re: [PATCH] Alter or rename enum value
In-reply-to: <d8jk2eoyn5u.fsf@dalvik.ping.uio.no>
References: 
 <CAO=2mx6uvgPaPDf-rHqG8=1MZnGyVDMQeh8zS4euRyyg4D35OQ@mail.gmail.com>
 <56E049CC.8010201@dunslane.net> <25605.1457539654@sss.pgh.pa.us>
 <56E05635.70908@dunslane.net> <28167.1457543612@sss.pgh.pa.us>
 <CAO=2mx4rQHRvifT2yUQ1rz90A=9CVz4_Z0Sx1wTgwgQRzAimpQ@mail.gmail.com>
 <CAO=2mx6rK_h4BC7y+3Nu-8fuZJXdFjd9FE_MZnzkH+vnMp0C-Q@mail.gmail.com>
 <d8ja8ln7nl0.fsf@dalvik.ping.uio.no> <d8jk2kn4yn0.fsf_-_@dalvik.ping.uio.no>
 <d8jeg5m4as8.fsf@dalvik.ping.uio.no>
 <CAE2gYzxo4bB_uQDafQYoGx=WmUrO-NFUbKBYfu4j_=LfaaUzFg@mail.gmail.com>
 <d8jy43m2wow.fsf@dalvik.ping.uio.no>
 <CAE2gYzy9fWFmMgnA0DstcGdtuFv40d3JXgtikE-ywtZ2qow=ng@mail.gmail.com>
 <26875.1472935684@sss.pgh.pa.us>
 <CAE2gYzzoWnzmz3MhiSr_49Mjjah4KXju-N81Bjc9p95-YcxpcA@mail.gmail.com>
 <32710.1473099022@sss.pgh.pa.us>
 <CA+Tgmoaz9OSD1Zbf4kMfEDV8OMGM6x2=kWxAxd1XPCfTWW1f8Q@mail.gmail.com>
 <8384.1473186627@sss.pgh.pa.us>
 <9dd58b5f-0447-54fe-02f4-afb62fd7c3c8@dunslane.net>
 <17893.1473193170@sss.pgh.pa.us> <CAE2gYzx=upAOfzHrsAuCsx6s6PajkG!
 ue7dT31dR1PoVa-CQD+w@mail.gmail.com> <d8jk2eoyn5u.fsf@dalvik.ping.uio.no>
Comments: In-reply-to ilmari@ilmari.org (Dagfinn Ilmari
 =?utf-8?Q?Manns=C3=A5ker?=)
	message dated "Wed, 07 Sep 2016 12:17:17 +0100"
Date: Wed, 07 Sep 2016 16:14:18 -0400
Message-ID: <30073.1473279258@sss.pgh.pa.us>
X-Pg-Spam-Score: -3.0 (---)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Here is version 6 of the patch, which just adds RENAME VALUE with no IF
> [NOT] EXISTS, rebased onto current master (particularly the
> transactional ADD VALUE patch).

Pushed with some adjustments.  The only thing that wasn't a matter of
taste is you forgot to update the backend/nodes/ support functions
for struct AlterEnumStmt.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers