public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alena Rybakina <[email protected]>
To: Ilia Evdokimov <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Ranier Vilela <[email protected]>
Subject: Re: pull-up subquery if JOIN-ON contains refs to upper-query
Date: Tue, 11 Feb 2025 18:59:55 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAEudQAoD707uh5Pjpg5NMyF-QO=fzajA+BmtcoqQAeXN1C+TkQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 10.02.2025 23:51, Ilia Evdokimov wrote:
>
> On 09.02.2025 18:14, Alena Rybakina wrote:
>> Hi! I found another example where the transformation worked 
>> incorrectly and reconsidered the idea.
>>
>> As for conversion of exists_sublink_to_ANY, we need to get the 
>> flattened implicit-AND list of clauses and pull out the chunks of the 
>> WHERE clause that belong to the parent query,
>> since we are called halfway through the parent's 
>> preprocess_expression() and earlier steps of preprocess_expression() 
>> wouldn't get applied to the pulled-up stuff unless we do them here.
>> We also do some processing for vars depending on which side the var 
>> is on - if it's in a subquery, we only need to lower its level 
>> (varlevel) because subquery will be flatted, while
>> for other vars that belong to the parent query, we need to do 
>> preparation to pull up the sub-select into top range table.
>>
>> For those expressions that we couldn't assign to either list, we 
>> define newWhere and apply both cases.
>>
>
> When I run 'make -C contrib/ check', tests of postgres_fdw extension 
> failed. I might be wrong, but you should be careful with LIMIT.
>
Thank you for the review, I'm working on it.

-- 
Regards,
Alena Rybakina
Postgres Professional

view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pull-up subquery if JOIN-ON contains refs to upper-query
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox