From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
cc: Noah Misch <noah@leadboat.com>, Robert Haas <robertmhaas@gmail.com>,
        Peter Geoghegan <pg@bowt.ie>, Thomas Munro <thomas.munro@gmail.com>,
        "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
        Stephen Frost <sfrost@snowman.net>,
        Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>,
        Dilip Kumar <dilipbalaut@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_amcheck contrib application
In-reply-to: <20210313191841.GB3195145@rfd.leadboat.com>
References: 
 <CAH2-WzmZJ3MWjaSEaysmkP8A7WL_TiCwOS8eT88yc-bwHgLOKg@mail.gmail.com>
 <CAH2-WznpwULZ3uJ1_6WXvNMXYbOy8k8tYs3r=qSdGmZeRd6tDw@mail.gmail.com>
 <CA+TgmoZUJ4j31CbnUz-DpBBq_DVoaYcuG5XB7hP71+uQ=js_KQ@mail.gmail.com>
 <CA+TgmoZ1DP0pkLyuG9y7Jtn2v7N-+dnVxbvBAT__u4-d=UYmbw@mail.gmail.com>
 <A80D68F6-E38F-482D-9522-E2FB6AAFE8A1@enterprisedb.com>
 <CA+TgmoY3_U=QuQWo4DArBSp+tg2MiCHLwDN_9U2H_iTxj3UcjA@mail.gmail.com>
 <9E76E46A-48B2-4869-BD0C-422204C1F767@enterprisedb.com>
 <F0A1FD70-A2F4-4528-8A03-8650CAEC0554@enterprisedb.com>
 <20210313184612.GA3195145@rfd.leadboat.com>
 <930621E5-5D10-456D-8CE4-CF629A6C4669@enterprisedb.com>
 <20210313191841.GB3195145@rfd.leadboat.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sat, 13 Mar 2021 11:18:41 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3012105.1615827854.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 15 Mar 2021 13:04:14 -0400
Message-ID: <3012106.1615827854@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3012106.1615827854%40sss.pgh.pa.us>
Precedence: bulk

Looks like we're not quite out of the woods, as hornet and tern are
still unhappy:

#   Failed test 'pg_amcheck excluding all corrupt schemas status (got 2 vs=
 expected 0)'
#   at t/003_check.pl line 498.

#   Failed test 'pg_amcheck excluding all corrupt schemas stdout /(?^:^$)/=
'
#   at t/003_check.pl line 498.
#                   'heap table "db1"."pg_catalog"."pg_statistic", block 2=
, offset 1, attribute 27:
#     final toast chunk number 0 differs from expected value 1
# heap table "db1"."pg_catalog"."pg_statistic", block 2, offset 1, attribu=
te 27:
#     toasted value for attribute 27 missing from toast table
# '
#     doesn't match '(?^:^$)'
# Looks like you failed 2 tests of 60.
[12:18:06] t/003_check.pl ........... =

Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/60 subtests =


These animals have somewhat weird alignment properties: MAXALIGN is 8
but ALIGNOF_DOUBLE is only 4.  I speculate that that is affecting their
choices about whether an out-of-line TOAST value is needed, breaking
this test case.

			regards, tom lane