Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u69Ea-00BtNK-OB for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Apr 2025 14:31:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u69EY-00F2o3-Pa for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Apr 2025 14:31:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u69EY-00F2nv-GE for pgsql-hackers@lists.postgresql.org; Sat, 19 Apr 2025 14:31:55 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u69EV-000v1l-35 for pgsql-hackers@postgresql.org; Sat, 19 Apr 2025 14:31:55 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 53JEVluP3014851; Sat, 19 Apr 2025 10:31:47 -0400 From: Tom Lane To: Andrew Dunstan cc: PostgreSQL-development , Jacob Champion Subject: Re: disabled SSL log_like tests In-reply-to: References: <984fca80-85a8-4c6f-a5cc-bb860950b435@dunslane.net> <2199758.1744901785@sss.pgh.pa.us> <1ce11d3f-624c-4003-a032-1b10cc138305@dunslane.net> <2814408.1745005558@sss.pgh.pa.us> <2859105.1745015195@sss.pgh.pa.us> <2915194.1745018792@sss.pgh.pa.us> Comments: In-reply-to Andrew Dunstan message dated "Sat, 19 Apr 2025 07:47:26 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <3014849.1745073107.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Sat, 19 Apr 2025 10:31:47 -0400 Message-ID: <3014850.1745073107@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > On 2025-04-18 Fr 7:26 PM, Tom Lane wrote: > +See C.  CAUTION: use of either option requires that > +the server's log_min_messages be at least DEBUG2, and that no other > +client backend is launched concurrently.  These requirements allow > +C to wait to see the postmaster-log report of backend > +exit, without which there is a race condition as to whether we will > +see the expected backend log output. > That seems a little fragile. I can imagine test authors easily > forgetting this. Is it worth sanity checking to make sure > log_min_messages is appropriately set? Setting log_min_messages is not so easily forgotten, because connect_fails will just hang until timeout if you didn't. I'm more worried about the "no other backend" requirement. I think v2 is reasonably proof against that, but whether it's sufficiently bulletproof to withstand the buildfarm environment remains to be seen. I wish there were a better way to determine the backend PID for a failed connection... regards, tom lane