Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNjHX-0003J4-UJ for pgsql-hackers@arkaria.postgresql.org; Sat, 20 Mar 2021 21:37:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lNjHW-0001mT-Rg for pgsql-hackers@arkaria.postgresql.org; Sat, 20 Mar 2021 21:37:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNjHW-0001mK-Ki for pgsql-hackers@lists.postgresql.org; Sat, 20 Mar 2021 21:37:14 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNjHU-0003C8-HO for pgsql-hackers@lists.postgresql.org; Sat, 20 Mar 2021 21:37:13 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 12KLb7gw301731; Sat, 20 Mar 2021 17:37:07 -0400 From: Tom Lane To: Justin Pryzby cc: Robert Haas , Dilip Kumar , Andres Freund , Tomas Vondra , Alexander Korotkov , David Steele , Ildus Kurbangaliev , Dmitry Dolgov <9erthalion6@gmail.com>, Andrey Borodin , pgsql-hackers@lists.postgresql.org Subject: Re: [HACKERS] Custom compression methods (mac+lz4.h) In-reply-to: <20210320212302.GW11765@telsasoft.com> References: <20210315225835.2toe2ceanp7gi6fw@alap3.anarazel.de> <20210319163511.GL11765@telsasoft.com> <20210319174425.GM11765@telsasoft.com> <20210320212302.GW11765@telsasoft.com> Comments: In-reply-to Justin Pryzby message dated "Sat, 20 Mar 2021 16:23:02 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <301729.1616276227.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 20 Mar 2021 17:37:07 -0400 Message-ID: <301730.1616276227@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Justin Pryzby writes: > On Fri, Mar 19, 2021 at 02:07:31PM -0400, Robert Haas wrote: >> On Fri, Mar 19, 2021 at 1:44 PM Justin Pryzby wr= ote: >>> configure: WARNING: lz4.h: accepted by the compiler, rejected by the p= reprocessor! >>> configure: WARNING: lz4.h: proceeding with the compiler's result >> No, I don't see this. I wonder whether this could possibly be an >> installation issue on Andrey's machine? If not, it must be >> version-dependent or installation-dependent in some way. > Andrey, can you check if latest HEAD (bbe0a81db) has these ./configure w= arnings ? FWIW, I also saw that, when building HEAD against MacPorts' version of liblz4 on an M1 Mac. config.log has configure:13536: checking lz4.h usability configure:13536: ccache clang -c -I/opt/local/include -Wall -Wmissing-prot= otype\ s -Wpointer-arith -Wdeclaration-after-statement -Werror=3Dvla -Wendif-labe= ls -Wmi\ ssing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno= -unus\ ed-command-line-argument -g -O2 -isysroot /Applications/Xcode.app/Contents= /Deve\ loper/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk conftest.c= >&5 configure:13536: $? =3D 0 configure:13536: result: yes configure:13536: checking lz4.h presence configure:13536: ccache clang -E -isysroot /Applications/Xcode.app/Content= s/Dev\ eloper/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk conftest.= c conftest.c:67:10: fatal error: 'lz4.h' file not found #include ^~~~~~~ 1 error generated. configure:13536: $? =3D 1 Digging around, it looks like the "-I/opt/local/include" bit came from LZ4_CFLAGS, which we then stuck into CFLAGS, but it needed to be put in CPPFLAGS in order to make this test work. regards, tom lane