From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Stephen Frost <sfrost@snowman.net>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Ian Barwick <ian.barwick@2ndquadrant.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
In-reply-to: 
 <CA+TgmoZmSQCta7eN_Y2+U4LthMxcutGB+YXs+0-i6ND2JY0TRA@mail.gmail.com>
References: <15032.1561403529@sss.pgh.pa.us>
 <20190624192014.GB2480@tamriel.snowman.net>
 <56aff4f3-dec8-f462-7feb-0938411b04a6@2ndquadrant.com>
 <CAA4eK1+JMm=tvx720y6jhD8pdzt=HdS1-TwQwkARib2pwK8EvQ@mail.gmail.com>
 <20190802222254.qsvqjtkwte464lu3@development>
 <31697.1564784856@sss.pgh.pa.us>
 <CAOuzzgqNyQM_z0biEEBVBK9WcaLmbCyWrd5xTdf-Oxb_9pntLA@mail.gmail.com>
 <20190802230011.dqokdhjptykopxxc@development>
 <20190805142139.GW29202@tamriel.snowman.net>
 <CA+Tgmoatso2sR=_LSSR443YjAfvQ48zpbYYVYQUHVMSoxsrJ9g@mail.gmail.com>
 <20190805172935.GK29202@tamriel.snowman.net>
 <CA+TgmoZmSQCta7eN_Y2+U4LthMxcutGB+YXs+0-i6ND2JY0TRA@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Mon, 05 Aug 2019 14:23:02 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30178.1565029753.1@sss.pgh.pa.us>
Date: Mon, 05 Aug 2019 14:29:13 -0400
Message-ID: <30179.1565029753@sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> All we need to do to resolve this issue is have Tom commit his patch.

I think Stephen is not being unreasonable to suggest that we need some
documentation about what external tools may safely do to pg.auto.conf.
So somebody's got to write that.  But I agree that we could go ahead
with the code patch.

(At this point I won't risk doing so before the wrap, though.)

			regards, tom lane