From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Michael Paquier <michael@paquier.xyz>,
        "Anton A. Melnikov" <a.melnikov@postgrespro.ru>,
        Daniel Gustafsson <daniel@yesql.se>,
        Peter Eisentraut <peter@eisentraut.org>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
In-reply-to: 
 <CA+TgmoaivCgqRCD+XKAVid=+W+zz1-GNN1SQFz2Bubtfn7vEMw@mail.gmail.com>
References: <0841ec77-47e5-452a-adb4-c6fa55d605fc@postgrespro.ru>
 <474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org>
 <44faf5a1-1e84-4ae5-9ea7-106af77cf96b@postgrespro.ru>
 <FC257A2E-D989-46DC-8232-AB14C3D7A0B2@yesql.se>
 <6457915f-f880-452d-a4ae-21a5bfbccbd3@postgrespro.ru>
 <ZimeCrx0IoiIQpJU@paquier.xyz>
 <CA+TgmoaivCgqRCD+XKAVid=+W+zz1-GNN1SQFz2Bubtfn7vEMw@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Fri, 26 Apr 2024 09:06:59 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <30206.1714164677.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 26 Apr 2024 16:51:17 -0400
Message-ID: <30207.1714164677@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/30207.1714164677%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Apr 24, 2024 at 8:04=E2=80=AFPM Michael Paquier <michael@paquier=
.xyz> wrote:
>> Not sure that I would bother with a second one.  But, well, why not if
>> people want to rename it, as long as you keep compatibility.

> I vote for just standardizing on XLOG_CONTROL_FILE. That name seems
> sufficiently intuitive to me, and I'd rather have one identifier for
> this than two. It's simpler that way.

+1.  Back when we did the great xlog-to-wal renaming, we explicitly
agreed that we wouldn't change internal symbols referring to xlog.
It might or might not be appropriate to revisit that decision,
but I sure don't want to do it piecemeal, one symbol at a time.

Also, if we did rename this one, the logical choice would be
WAL_CONTROL_FILE not PG_CONTROL_FILE.

			regards, tom lane