From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Laurenz Albe <laurenz.albe@cybertec.at>, pgsql-hackers@postgresql.org
Subject: Re: Use -fvisibility=hidden for shared libraries
In-reply-to: <20220718220938.5yx7if2mru3rd6jc@awork3.anarazel.de>
References: <20211101020311.av6hphdl6xbjbuif@alap3.anarazel.de>
 <b8103d16bf26cff7a393d1de690474dbd9afaa19.camel@cybertec.at>
 <20211101054700.z3jzmc5lnxlad4y7@alap3.anarazel.de>
 <2499085.1641859296@sss.pgh.pa.us>
 <20220111025328.iq5g6uck53j5qtin@alap3.anarazel.de>
 <5b8d48a4-2fee-6764-7eda-a076f544ea33@enterprisedb.com>
 <20220716201750.qq6xwegkgp7xqi5w@awork3.anarazel.de>
 <180138.1658084088@sss.pgh.pa.us>
 <20220718070516.z4suhhdomktmrenb@awork3.anarazel.de>
 <20220718220938.5yx7if2mru3rd6jc@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 18 Jul 2022 15:09:38 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3022535.1658944948.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 27 Jul 2022 14:02:28 -0400
Message-ID: <3022536.1658944948@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3022536.1658944948%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-07-18 00:05:16 -0700, Andres Freund wrote:
>> Given that that's just about all compilers we support using configure, =
perhaps
>> we should just move that out of the compiler specific section? Doesn't =
look
>> like there's much precedent for that so far...

> Here's a potential patch along those lines.

Now that the dust from the main patch is pretty well settled, +1
for trying that.

> I wonder if we also should move the -fno-strict-aliasing, -fwrapv tests
> out. But that'd be something for later.

Those seem less likely to be portable to non-gcc-alike compilers.
On the other hand, maybe it'd be interesting to just remove the
conditionality temporarily and try ALL the switches on all compilers,
just to see what we can learn from the buildfarm.

			regards, tom lane