From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Jeff Janes <jeff.janes@gmail.com>,
        Michael Paquier <michael.paquier@gmail.com>,
        PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Reducing pg_ctl's reaction time
In-reply-to: <20170627200544.2czwjtdtyy4gr4sv@alap3.anarazel.de>
References: <18890.1498508760@sss.pgh.pa.us>
 <20170626203347.6efkdwiadyt33edy@alap3.anarazel.de>
 <19812.1498510147@sss.pgh.pa.us>
 <20170626205853.ezhnmxpotdy3wokm@alap3.anarazel.de>
 <15166.1498512630@sss.pgh.pa.us>
 <20170626213414.ejcesidei2hv4h5x@alap3.anarazel.de>
 <15732.1498513083@sss.pgh.pa.us>
 <20170626215018.2fudv2aha5rkkg4r@alap3.anarazel.de>
 <17327.1498515236@sss.pgh.pa.us> <15323.1498589958@sss.pgh.pa.us>
 <20170627200544.2czwjtdtyy4gr4sv@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 27 Jun 2017 13:05:44 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30237.1498671087.1@sss.pgh.pa.us>
Date: Wed, 28 Jun 2017 13:31:27 -0400
Message-ID: <30238.1498671087@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> On 2017-06-27 14:59:18 -0400, Tom Lane wrote:
>> However, it's certainly arguable that this is too much change for an
>> optional post-beta patch.

> Yea, I think there's a valid case to be made for that. I'm still
> inclined to go along with this, it seems we're otherwise just adding
> complexity we're going to remove in a bit again.

I'm not hearing anyone speaking against doing this now, so I'm going
to go ahead with it.

> The 8-space thing in multiple places is a bit ugly.  How about having a
> a bunch of constants declared in one place?

While looking this over again, I got worried about the fact that pg_ctl
is #including "miscadmin.h".  That's a pretty low-level backend header
and it wouldn't be surprising at all if somebody tried to put stuff in
it that wouldn't compile frontend-side.  I think we should take the
opportunity, as long as we're touching this stuff, to split the #defines
that describe the contents of postmaster.pid into a separate header file.
Maybe "utils/pidfile.h" ?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers