From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Greg Burd <greg@burd.me>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Robert Haas <robertmhaas@gmail.com>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Masahiko Sawada <sawada.mshk@gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
In-reply-to: <aNEBUeYqqSVOSVaP@paquier.xyz>
References: <aMz57nHgkLozddYu@paquier.xyz>
 <CD368B71-2947-407D-8967-181A4CB4A985@greg.burd.me>
 <aNEBUeYqqSVOSVaP@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 22 Sep 2025 16:57:05 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3027068.1758606227.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 23 Sep 2025 01:43:47 -0400
Message-ID: <3027069.1758606227@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3027069.1758606227%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> The result I had was good enough, so applied.  The CI was OK, the
> buildfarm may have a different opinion.

This patch seems to be rather full of arbitrary casts to or
from Datum, which is no longer okay.  You need to be using
the appropriate conversion macros, such as PointerGetDatum.

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dmamba&dt=3D2025-=
09-23%2002%3A12%3A36

			regards, tom lane