From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: exclusion@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: fix crash with Python 3.11
In-reply-to: <1533956.1645731245@sss.pgh.pa.us>
References: <3375ffd8-d71c-2565-e348-a597d6e739e3@enterprisedb.com>
 <3890110.1642373624@sss.pgh.pa.us>
 <73daabb7-9fc7-fb7a-5e06-a968c611b032@enterprisedb.com>
 <2255118.1643126084@sss.pgh.pa.us>
 <bd4dd309-c889-c20c-6be8-a3943cd94882@enterprisedb.com>
 <1103370.1644273481@sss.pgh.pa.us> <1216692.1645644682@sss.pgh.pa.us>
 <1533956.1645731245@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 24 Feb 2022 14:34:05 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3027327.1655829211.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 21 Jun 2022 12:33:31 -0400
Message-ID: <3027328.1655829211@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3027328.1655829211%40sss.pgh.pa.us>
Precedence: bulk

Is it time yet to back-patch 2e517818f ("Fix SPI's handling of errors
during transaction commit")?  We know we're going to have to do it
before Python 3.11 ships, and it's been stable in HEAD for 3.5 months
now.  Also, the Fedora guys absorbed the patch a couple weeks ago [1]
because they're already using 3.11 in rawhide, and I've not heard
complaints from that direction.

My inclination at this point is to not back-patch the second change
12d768e70 ("Don't use static storage for SaveTransactionCharacteristics").
It's not clear that the benefit would be worth even a small risk of
somebody being unhappy about the API break.

			regards, tom lane

[1] https://www.postgresql.org/message-id/flat/CA%2BHKMWMY_e2otmTJDjKUAvC8=
Urh4rzSWOPZ%3DfszU5brkBP97ng%40mail.gmail.com