Feedback-ID: i131946ab:Fastmail
Message-ID: <302a562e-f766-bf0f-f76d-e6b232bf8870@enterprisedb.com>
Date: Wed, 15 Jun 2022 11:14:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: Add header support to text format and matching feature
Content-Language: en-US
To: Julien Rouhaud <rjuju123@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>, Greg Stark <stark@mit.edu>,
 =?UTF-8?Q?R=c3=a9mi_Lapeyre?= <remi.lapeyre@lenstra.fr>,
 Zhihong Yu <zyu@yugabyte.com>, David Steele <david@pgmasters.net>,
 vignesh C <vignesh21@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Daniel Verite <daniel@manitou-mail.org>
References: <07891B9D-2140-4C06-AF96-C14F1E1B0E8E@lenstra.fr>
 <f62f0262-2a3c-8839-5ced-25ca2421d738@enterprisedb.com>
 <8eba1968-9503-5be7-b473-37383f17bb72@enterprisedb.com>
 <CAM-w4HPkjYQGPm0-zx3XZHnQ_+B8AyWuCn_LyTeX7sNJCv4x8A@mail.gmail.com>
 <ae4dc590-090f-ae9b-6fdb-01a901dd4841@enterprisedb.com>
 <206ac69a-4e47-c49a-66ae-e748c339ba35@enterprisedb.com>
 <20220607154744.vvmitnqhyxrne5ms@jrouhaud>
 <d35e05ac-fde1-0dba-39bf-b30e75082b48@dunslane.net>
 <20220613023213.bj7qjnplvgfmx522@jrouhaud> <YqbrZm4VdoEEcnJl@paquier.xyz>
 <20220614091319.jk4he5migtpwyd7r@jrouhaud>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220614091319.jk4he5migtpwyd7r@jrouhaud>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/302a562e-f766-bf0f-f76d-e6b232bf8870%40enterprisedb.com>
Precedence: bulk


On 14.06.22 11:13, Julien Rouhaud wrote:
>> There is no need for the extra
>> comment, and the error code should be ERRCODE_FEATURE_NOT_SUPPORTED.
> Is there any rule for what error code should be used?
> 
> Maybe that's just me but I understand "not supported" as "this makes sense, but
> this is currently a limitation that might be lifted later".

I tend to agree with that interpretation.

Also, when you consider the way SQL rules and error codes are set up, 
errors that are detected during parse analysis should be a subclass of 
"syntax error or access rule violation".