Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbihr-0007Qy-2X for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Apr 2022 12:54:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nbihp-000521-Cr for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Apr 2022 12:54:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbihp-00051s-3l for pgsql-hackers@lists.postgresql.org; Tue, 05 Apr 2022 12:54:45 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbihl-0008TB-SV for pgsql-hackers@postgresql.org; Tue, 05 Apr 2022 12:54:43 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id A3A2E240004; Tue, 5 Apr 2022 12:54:37 +0000 (UTC) Message-ID: <3031fc19-7540-b8be-e34b-835e6fc4493e@dunslane.net> Date: Tue, 5 Apr 2022 08:54:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: Run pg_amcheck in 002_pg_upgrade.pl and 027_stream_regress.pl? Content-Language: en-US To: Peter Geoghegan , Andres Freund Cc: PostgreSQL Hackers , Mark Dilger , Robert Haas References: <20220403185303.futnxfj64llw4uny@alap3.anarazel.de> From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 4/3/22 22:10, Peter Geoghegan wrote: > On Sun, Apr 3, 2022 at 11:53 AM Andres Freund wrote: >> We've had bugs in pg_upgrade where post-upgrade xid horizons weren't correctly >> set. We've had bugs were indexes were corrupted during replay. >> >> The latter can be caught by wal_consistency_checking - but that's pretty >> expensive. >> >> It seems $subject would have a chance of catching some of these bugs, as well >> as exposing amcheck to a database with a bit more varied content? > I thought that Andrew Dunstan (CC'd) had a BF animal that did this > setup. But I'm not sure if that ever ended up happening. I don't think any of my BF animals do anything special in this area. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com