Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyKU9-0000Dw-PQ for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 16:51:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyKU9-0007Yp-0J for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 16:51:41 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyKTS-0002z8-7e for pgsql-hackers@lists.postgresql.org; Tue, 20 Mar 2018 16:50:58 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyKTP-0003Aa-86 for pgsql-hackers@lists.postgresql.org; Tue, 20 Mar 2018 16:50:56 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w2KGoiq5030399; Tue, 20 Mar 2018 12:50:44 -0400 From: Tom Lane To: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) cc: Craig Ringer , PostgreSQL Hackers Subject: Re: configure's checks for --enable-tap-tests are insufficient In-reply-to: References: <516.1521475003@sss.pgh.pa.us> <8906.1521513602@sss.pgh.pa.us> <9696.1521554152@sss.pgh.pa.us> <12134.1521556826@sss.pgh.pa.us> Comments: In-reply-to ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) message dated "Tue, 20 Mar 2018 16:43:07 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <30397.1521564644.1@sss.pgh.pa.us> Date: Tue, 20 Mar 2018 12:50:44 -0400 Message-ID: <30398.1521564644@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Tom Lane writes: >> ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >>> I think the other way would be better simpler: we require a complete >>> Perl core installation. >> And you propose to test for that in configure how? > Good point, I'd overlooked that aspect. In that case we can't rely on > what Debian or others happen to include in their minimal packages, we > have to explicitly check for _every_ module we use anywhere in the test > suite, core or not (except perhaps pragmas like 'strict' and 'warnings'). That seems like expensive overkill to me, especially since it seems unlikely that we'd keep the list up-to-date over time. I just want to test for modules that we know are likely to be omitted on popular platforms. I've proposed testing two that would improve the user experience on Red Hat; what's the equivalent minimum set for Debian? I think the documentation can reasonably say that we expect perl-core (plus IPC::Run, if that's not core). But configure's task is just to make a reasonable attempt to notice if you're missing something. If we have to tweak it again in the future, that's fine with me. regards, tom lane