From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Unstable regression test for contrib/pageinspect
In-reply-to: 
 <CAH2-Wz=3vJhW9CttOREb3ObDq0VdZFUgdgwu1_x=Ra_MFFskDQ@mail.gmail.com>
References: <2892135.1668976646@sss.pgh.pa.us>
 <CAH2-Wz=3vJhW9CttOREb3ObDq0VdZFUgdgwu1_x=Ra_MFFskDQ@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Sun, 20 Nov 2022 13:09:03 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3044432.1669005973.1@sss.pgh.pa.us>
Date: Sun, 20 Nov 2022 23:46:13 -0500
Message-ID: <3044433.1669005973@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3044433.1669005973%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> On Sun, Nov 20, 2022 at 12:37 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The core reloptions.sql and vacuum.sql tests are two places that are
>> also using this option, but they are applying it to temp tables,
>> which I think makes it safe (and the lack of failures, seeing that
>> they run within parallel test groups, reinforces that).  Can we apply
>> that idea in pageinspect?

> I believe so. The temp table horizons guarantee isn't all that old, so
> the tests may well have been written before it was possible.

Ah, right, I see that that only dates back to v14 (cf a7212be8b).
So we can fix pageinspect's issue by making that table be temp,
but only as far back as v14.

That's probably good enough in terms of reducing the buildfarm
noise level, seeing that mamba has only reported this failure
on HEAD so far.  I'd be tempted to propose back-patching
a7212be8b, but there would be ABI-stability issues, and it's
probably not worth dealing with that.

>> contrib/amcheck and contrib/pg_visibility are also using
>> DISABLE_PAGE_SKIPPING, so I wonder if they have similar hazards.

> I think that most use of DISABLE_PAGE_SKIPPING by the regression tests
> just isn't necessary.

Apparently not -- see followup discussion with Mark Dilger.

			regards, tom lane