Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1l64xK-0004RE-Oi
	for pgsql-hackers@arkaria.postgresql.org; Sun, 31 Jan 2021 05:07:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1l64xH-0006oT-9X
	for pgsql-hackers@arkaria.postgresql.org; Sun, 31 Jan 2021 05:07:23 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1l64xH-0006oM-2x
	for pgsql-hackers@lists.postgresql.org; Sun, 31 Jan 2021 05:07:23 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1l64xC-0006RB-U6
	for pgsql-hackers@postgresql.org; Sun, 31 Jan 2021 05:07:22 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 10V5718J3054077;
	Sun, 31 Jan 2021 00:07:01 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        Heikki Linnakangas <hlinnaka@iki.fi>,
        Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        "Bossart,
    Nathan" <bossartn@amazon.com>
Subject: Re: shared tempfile was not removed on statement_timeout
In-reply-to: 
 <CA+hUKGLZ7Yu+_BTmx0B_xpjJoVMEPA-urB6pWq0if3MUxU=ypw@mail.gmail.com>
References: 
 <CA+fd4k4k0QQv=7m2GkXQqi7toy1EU8JUjo6P+u8iw2NKYdzqrA@mail.gmail.com>
 <20210126.134618.1349022761868530379.horikyota.ntt@gmail.com>
 <595f8632-40a0-99e1-404b-2c1156b953a8@iki.fi>
 <20210126.202221.279021416570521917.horikyota.ntt@gmail.com>
 <CA+hUKG+MsPtVpBEkMhUv=01ApLUNz61CHoGAzd7etbhQY4sD=A@mail.gmail.com>
 <CA+hUKGLZ7Yu+_BTmx0B_xpjJoVMEPA-urB6pWq0if3MUxU=ypw@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Sun, 31 Jan 2021 14:26:31 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3054075.1612069621.1@sss.pgh.pa.us>
Date: Sun, 31 Jan 2021 00:07:01 -0500
Message-ID: <3054076.1612069621@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
>> +1, this seems like a good idea.  This is a little bit like the code
>> near the comments "Don't joggle the elbow of proc_exit".

> So that gives a very simple back-patchable patch.

Hmm, so is the *rest* of that function perfectly okay with being
interrupted?

			regards, tom lane