From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        "Bossart,
    Nathan" <bossartn@amazon.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        "andres@anarazel.de" <andres@anarazel.de>,
        "masao.fujii@oss.nttdata.com" <masao.fujii@oss.nttdata.com>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>,
        "mengjuan.cmj@alibaba-inc.com" <mengjuan.cmj@alibaba-inc.com>,
        "Jakub.Wartak@tomtom.com" <Jakub.Wartak@tomtom.com>,
        Ryo Matsumura <matsumura.ryo@fujitsu.com>
Subject: Re: prevent immature WAL streaming
In-reply-to: <97ccf47e-e4f9-28b6-e780-83821f1da69c@dunslane.net>
References: <202109291443.dxsnnji7a4dq@alvherre.pgsql>
 <3000074.1632947632@sss.pgh.pa.us>
 <06126430-07db-7051-a4c7-17edbe4ac34e@dunslane.net>
 <3003011.1632950979@sss.pgh.pa.us>
 <97ccf47e-e4f9-28b6-e780-83821f1da69c@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Thu, 30 Sep 2021 10:18:39 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3060990.1633012112.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Thu, 30 Sep 2021 10:28:32 -0400
Message-ID: <3060991.1633012112@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3060991.1633012112%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> Regardless of this problem, I think we should simply call
> set_replication_conf unconditionally in init().  Replication connections
> are now allowed by default on Unix, this would just bring Windows nodes
> into line with that.

Yeah, I was thinking along the same lines yesterday.  The fact that
pre-commit testing failed to note the problem is exactly because we
have this random difference between what works by default on Unix
and what works by default on Windows.  Let's close that gap before
it bites us again.

There's still the issue of these tests overriding postgresql.conf
entries made by init(), but maybe we can live with that?

			regards, tom lane