From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unix-domain socket support on Windows
In-reply-to: <3b5fed50-9017-49ca-b556-303a0cc1b660@2ndquadrant.com>
References: <54bde68c-d134-4eb8-5bd3-8af33b72a010@2ndquadrant.com>
 <00d4945e-b437-f3b5-f4af-42e99321c846@2ndquadrant.com>
 <CA+hUKGLkUTNjRZC9e4XjvLQCXL9Dre5ZQhoPqN+rZWbGYV1BQA@mail.gmail.com>
 <fe46da42-00f0-ef1f-ab52-456df58b5bff@2ndquadrant.com>
 <5974caea-1267-7708-40f2-6009a9d653b0@2ndquadrant.com>
 <CAA8=A7-VsWR9Z8Dg0XWTreP_x5=u2cXpGgJymy8-_yesEpHMFg@mail.gmail.com>
 <ce26e70c-cfa6-2f47-5c33-f88bc4d4f288@2ndquadrant.com>
 <75f72249-8ae6-322a-63df-4fe03eeccb9f@2ndquadrant.com>
 <3b5fed50-9017-49ca-b556-303a0cc1b660@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Thu, 30 Jan 2020 19:28:00 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30626.1580409696.1@sss.pgh.pa.us>
Date: Thu, 30 Jan 2020 13:41:36 -0500
Message-ID: <30627.1580409696@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-12-18 14:52, Peter Eisentraut wrote:
>> We have code paths for Unix socket support and no Unix socket support.
>> Now add a third variant: Unix socket support but do not use a Unix
>> socket by default in the client or the server, only if you explicitly
>> specify one.
>> 
>> To implement this, tweak things so that setting DEFAULT_PGSOCKET_DIR
>> to "" has the desired effect.  This mostly already worked like that;
>> only a few places needed to be adjusted.  Notably, the reference to
>> DEFAULT_PGSOCKET_DIR in UNIXSOCK_PATH() could be removed because all
>> callers already resolve an empty socket directory setting with a
>> default if appropriate.

> Perhaps this patch is too boring to be reviewed.  If there are no 
> objections, I'll commit it soon and then submit the final patches with 
> the real functionality for the next commit fest.

Sorry, I'd paid no particular attention to this thread because
I figured it'd take a Windows-competent person to review.  But
the patch as it stands isn't that.

The code looks fine (and a big +1 for not having knowledge of
DEFAULT_PGSOCKET_DIR wired into UNIXSOCK_PATH).  I wonder though
whether any user-facing documentation needs to be adjusted.

			regards, tom lane