From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: Xing Guo <higuoxing@gmail.com>, Andreas Karlsson <andreas@proxel.se>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: JIT: The nullness of casetest.value can be determined at the JIT compile time.
In-reply-to: <1c767ec4-709e-45b1-bc0e-add024326e77@iki.fi>
References: <CACpMh+AiBYAWn+D1aU7Rsy-V1tox06Cbc0H3qA7rwL5zdJ=anQ@mail.gmail.com> <abeaa792-1db5-4438-b72f-fdc7a1c444ab@proxel.se> <CACpMh+AWarmG=aKy6KUyyWVTKLedBJzZMTQG3TKPN5EGVii9TA@mail.gmail.com> <1c767ec4-709e-45b1-bc0e-add024326e77@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Fri, 15 Nov 2024 11:38:08 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3070950.1738207772.1@sss.pgh.pa.us>
Date: Wed, 29 Jan 2025 22:29:32 -0500
Message-ID: <3070951.1738207772@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3070951.1738207772%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Huge +1 for cleaning up this abuse of caseValue_datum/domainValue_datum. 
> While correct and sensible if we continue the abuse, these patches feel 
> like putting lipstick on a pig.

Agreed.  I spent some time trying to do it better, with results
shown at [1].  If we adopt that idea, then the executor's support
for CaseTestExpr will go away, so there's little point in pursuing
that half of the patch given here.  However, I concluded that there's
insufficient reason to redesign CoerceToDomainValue, so we could
still push forward with that half of this patch.

			regards, tom lane

[1] https://www.postgresql.org/message-id/3068812.1738206654@sss.pgh.pa.us