Subject: Re: HEAPDEBUGALL is broken
To: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <3070eb7d-e06d-31a0-5b68-4ae088fd146c@gmail.com>
Date: Sun, 19 Apr 2020 23:00:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com>
Content-Type: multipart/alternative;
 boundary="------------A3D7311BE6913FCF19CB599E"
Content-Language: ru-RU
Precedence: bulk

This is a multi-part message in MIME format.
--------------A3D7311BE6913FCF19CB599E
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Hello hackers,
19.04.2020 13:37, Tom Lane wrote:
>
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> The HEAPDEBUGALL define has been broken since PG12 due to tableam
>> changes.  Should we just remove this?  It doesn't look very useful.
>> It's been around since Postgres95.
>> If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL
>> (which still compiles correctly).  Would we want to keep that?
>
> +1 for removing both.  There are a lot of such debug "features"
> in the code, and few of them are worth anything IME.
To the point, I've tried to use HAVE_ALLOCINFO on master today and it
failed too:
$ CPPFLAGS="-DHAVE_ALLOCINFO" ./configure --enable-tap-tests
--enable-debug --enable-cassert  >/dev/null && make -j16 >/dev/null
generation.c: In function ‘GenerationAlloc’:
generation.c:191:11: error: ‘GenerationContext {aka struct
GenerationContext}’ has no member named ‘name’
     (_cxt)->name, (_chunk), (_chunk)->size)
           ^
generation.c:386:3: note: in expansion of macro ‘GenerationAllocInfo’
   GenerationAllocInfo(set, chunk);
   ^~~~~~~~~~~~~~~~~~~
generation.c:191:11: error: ‘GenerationContext {aka struct
GenerationContext}’ has no member named ‘name’
     (_cxt)->name, (_chunk), (_chunk)->size)
           ^
generation.c:463:2: note: in expansion of macro ‘GenerationAllocInfo’
  GenerationAllocInfo(set, chunk);
  ^~~~~~~~~~~~~~~~~~~

Best regards,
Alexander

--------------A3D7311BE6913FCF19CB599E
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hello hackers,<br>
      19.04.2020 13:37, Tom Lane wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:%3C645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com%3E"><br>
      Peter Eisentraut <a class="moz-txt-link-rfc2396E"
        href="mailto:peter.eisentraut@2ndquadrant.com"
        moz-do-not-send="true">&lt;peter.eisentraut@2ndquadrant.com&gt;</a>
      writes:
      <br>
      <blockquote type="cite" style="color: #000000;">The HEAPDEBUGALL
        define has been broken since PG12 due to tableam changes. 
        Should we just remove this?  It doesn't look very useful. It's
        been around since Postgres95.
        <br>
        If we opt for removing: PG12 added an analogous
        HEAPAMSLOTDEBUGALL (which still compiles correctly).  Would we
        want to keep that?
        <br>
      </blockquote>
      <br>
      +1 for removing both.  There are a lot of such debug "features"
      <br>
      in the code, and few of them are worth anything IME.
      <br>
    </blockquote>
    To the point, I've tried to use HAVE_ALLOCINFO on master today and
    it failed too:<br>
    $ CPPFLAGS="-DHAVE_ALLOCINFO" ./configure --enable-tap-tests
    --enable-debug --enable-cassert  &gt;/dev/null &amp;&amp; make -j16
    &gt;/dev/null<br>
    generation.c: In function ‘GenerationAlloc’:<br>
    generation.c:191:11: error: ‘GenerationContext {aka struct
    GenerationContext}’ has no member named ‘name’<br>
         (_cxt)-&gt;name, (_chunk), (_chunk)-&gt;size)<br>
               ^<br>
    generation.c:386:3: note: in expansion of macro
    ‘GenerationAllocInfo’<br>
       GenerationAllocInfo(set, chunk);<br>
       ^~~~~~~~~~~~~~~~~~~<br>
    generation.c:191:11: error: ‘GenerationContext {aka struct
    GenerationContext}’ has no member named ‘name’<br>
         (_cxt)-&gt;name, (_chunk), (_chunk)-&gt;size)<br>
               ^<br>
    generation.c:463:2: note: in expansion of macro
    ‘GenerationAllocInfo’<br>
      GenerationAllocInfo(set, chunk);<br>
      ^~~~~~~~~~~~~~~~~~~<br>
    <br>
    Best regards,<br>
    Alexander<br>
  </body>
</html>

--------------A3D7311BE6913FCF19CB599E--