public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Tomas Vondra <[email protected]>
Cc: [email protected]
Subject: Re: Improve hash join's handling of tuples with null join keys
Date: Mon, 05 May 2025 20:58:31 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Tomas Vondra <[email protected]> writes:
> My personal experience is that the growEnabled heuristics is overly
> sensitive, and probably does not trigger very often.

Yeah, it would be good to make it not quite all-or-nothing.

> But more importantly, wasn't the issue discussed in [1] about parallel
> hash joins?

I'm not clear on that either; it seemed that the OP was able to
trigger it in some non-parallel cases too.  But we don't have a
reproducer so I can't say for sure.  Building a reproducer would
be a useful exercise for testing this.  There might well be some
parallel-specific misbehavior that would be worth ameliorating
independently of this work, in case of a lot of non-null duplicate
keys.

>> This passes check-world, and I've extended a couple of existing test
>> cases to ensure that the new code paths are exercised.  I've not done
>> any real performance testing, though.

> Are you planning to? If not, I can try to collect some numbers, but I
> can't promise that before pgconf.dev.

If you have time after the conference, please feel free.

> BTW do you consider this to be a bugfix for PG18? Or would it have to
> wait for PG19 at this point?

This has been like this forever I suspect --- certainly for as long
as we've had PHJ, and probably longer.  So I'm seeing it as new work
for v19, not something we'd attempt to back-patch.

			regards, tom lane

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Improve hash join's handling of tuples with null join keys
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox