Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id C785B632396 for ; Thu, 22 Jan 2009 03:35:57 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 40781-10 for ; Thu, 22 Jan 2009 03:35:55 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.234]) by mail.postgresql.org (Postfix) with ESMTP id 1A89F62D9BF for ; Thu, 22 Jan 2009 03:35:54 -0400 (AST) Received: by rv-out-0506.google.com with SMTP id b25so4150501rvf.43 for ; Wed, 21 Jan 2009 23:35:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.141.155.15 with SMTP id h15mr2376460rvo.158.1232609753195; Wed, 21 Jan 2009 23:35:53 -0800 (PST) In-Reply-To: <497748B3.6010008@gmx.net> References: <497748B3.6010008@gmx.net> Date: Thu, 22 Jan 2009 02:35:53 -0500 Message-ID: <3073cc9b0901212335j45443861ude0dd25aeb13b8b3@mail.gmail.com> Subject: Re: WIP: Automatic view update rules From: Jaime Casanova To: Peter Eisentraut Cc: Bernd Helmle , pgsql-hackers@postgresql.org Content-Type: multipart/mixed; boundary=000e0cd14f387c659904610d5205 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200901/1602 X-Sequence-Number: 132246 --000e0cd14f387c659904610d5205 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Wed, Jan 21, 2009 at 11:09 AM, Peter Eisentraut wrote: > Here is my latest reworked patch that fixes all outstanding issues. > > 1) there's a regression failure, it's just a message that changes... attached regression.diffs 2) this comment on src/backend/rewrite/viewUpdate.c:form_where_for_updrule() is no longer true """ /* * Finally, create the OpExpr node, as part of a CaseExpr and * include the OpExpr as part of the Case for managing NULL's * we will do this everytime. That way we will have no * problem with: * * ALTER TABLE ... ALTER COLUMN ... DROP NOT NULL; */ """ --=20 Atentamente, Jaime Casanova Soporte y capacitaci=F3n de PostgreSQL Asesor=EDa y desarrollo de sistemas Guayaquil - Ecuador Cel. +59387171157 --000e0cd14f387c659904610d5205 Content-Type: application/octet-stream; name="regression.diffs" Content-Disposition: attachment; filename="regression.diffs" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fq93x8ci1 KioqIC9ob21lL3Bvc3RncmVzL3Bnc3FsLnZpZXd1cGRhdGUvc3JjL3Rlc3QvcmVncmVzcy9leHBl Y3RlZC92aWV3X3VwZGF0ZS5vdXQJVGh1IEphbiAyMiAwMjoxNzo1NCAyMDA5Ci0tLSAvaG9tZS9w b3N0Z3Jlcy9wZ3NxbC52aWV3dXBkYXRlL3NyYy90ZXN0L3JlZ3Jlc3MvcmVzdWx0cy92aWV3X3Vw ZGF0ZS5vdXQJVGh1IEphbiAyMiAwMjoyNToxMyAyMDA5CioqKioqKioqKioqKioqKgoqKiogNDAs NDYgKioqKgogIElOU0VSVCBJTlRPIHZ1dGVzdHYzIChhLCBiKSBWQUxVRVMgKDYsICdzaXgnKTsK ICBJTlNFUlQgSU5UTyB2dXRlc3R2NCBWQUxVRVMgKDcsICdzZXZlbicpOyAgLS0gb2ssIGJ1dCB3 b3VsZCBiZSBjaGVjayBvcHRpb24gaXNzdWUKICBJTlNFUlQgSU5UTyB2dXRlc3R2NSBWQUxVRVMg KDgpOyAgLS0gZmFpbAohIEVSUk9SOiAgdmlldyBpcyBub3QgaW5zZXJ0YWJsZSBpbnRvCiAgSElO VDogIFlvdSBuZWVkIGFuIHVuY29uZGl0aW9uYWwgT04gSU5TRVJUIERPIElOU1RFQUQgcnVsZS4K ICBTRUxFQ1QgKiBGUk9NIHZ1dGVzdDE7CiAgIGEgfCAgIGIgICAKLS0tIDQwLDQ2IC0tLS0KICBJ TlNFUlQgSU5UTyB2dXRlc3R2MyAoYSwgYikgVkFMVUVTICg2LCAnc2l4Jyk7CiAgSU5TRVJUIElO VE8gdnV0ZXN0djQgVkFMVUVTICg3LCAnc2V2ZW4nKTsgIC0tIG9rLCBidXQgd291bGQgYmUgY2hl Y2sgb3B0aW9uIGlzc3VlCiAgSU5TRVJUIElOVE8gdnV0ZXN0djUgVkFMVUVTICg4KTsgIC0tIGZh aWwKISBFUlJPUjogIHZpZXcgaXMgbm90IHVwZGF0YWJsZQogIEhJTlQ6ICBZb3UgbmVlZCBhbiB1 bmNvbmRpdGlvbmFsIE9OIElOU0VSVCBETyBJTlNURUFEIHJ1bGUuCiAgU0VMRUNUICogRlJPTSB2 dXRlc3QxOwogICBhIHwgICBiICAgCgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Cgo= --000e0cd14f387c659904610d5205--