From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@postgresql.org, Michael Paquier <michael.paquier@gmail.com>,
        Fujii Masao <fujii@postgresql.org>
Subject: Re: tests against running server occasionally fail, postgres_fdw & tenk1
In-reply-to: <20230226194340.u44bkfgyz64c67i6@awork3.anarazel.de>
References: <20221209001511.n3vqodxobqgscuil@awork3.anarazel.de> <20230226194340.u44bkfgyz64c67i6@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sun, 26 Feb 2023 11:43:40 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30781.1677441105.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 26 Feb 2023 14:51:45 -0500
Message-ID: <30782.1677441105@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/30782.1677441105%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-12-08 16:15:11 -0800, Andres Freund wrote:
>> The most frequent case is postgres_fdw, which somewhat regularly fails =
with a
>> regression.diff like this:
>> WHERE application_name =3D 'fdw_retry_check';
>> pg_terminate_backend
>> ----------------------
>> - t
>> -(1 row)
>> +(0 rows)

> Unless somebody comes up with a way to make the test more reliable prett=
y
> soon, I think we should just remove it. It's one of the most frequently
> flapping tests at the moment.

If that's the only diff, we could just hide it, say by writing

do $$ begin
PERFORM pg_terminate_backend(pid, 180000) FROM pg_stat_activity
WHERE application_name =3D 'fdw_retry_check';
end $$;

The actually important thing is the failure check after this;
we don't care that much whether the initially-created connection
is still live at this point.

			regards, tom lane