Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hB0rv-0000ZS-Hb
	for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 17:37:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hB0rt-0001QU-3M
	for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 17:37:09 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hB0rs-0001QN-RN
	for pgsql-hackers@lists.postgresql.org; Mon, 01 Apr 2019 17:37:08 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hB0rm-0002ew-FA
	for pgsql-hackers@postgresql.org; Mon, 01 Apr 2019 17:37:08 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x31Hawo2030786;
	Mon, 1 Apr 2019 13:36:58 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Noah Misch <noah@leadboat.com>, pgsql-hackers@postgresql.org
Subject: Re: Extending USE_MODULE_DB to more test suite types
In-reply-to: <20190401170658.ugoa7babvrxw2paa@alap3.anarazel.de>
References: <20190401135213.GE891537@rfd.leadboat.com>
 <20190401170658.ugoa7babvrxw2paa@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 01 Apr 2019 10:06:58 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30784.1554140218.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 01 Apr 2019 13:36:58 -0400
Message-ID: <30785.1554140218@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2019-04-01 06:52:13 -0700, Noah Misch wrote:
>> I plan to back-patch the PostgreSQL patch, to combat buildfarm noise.  =
Perhaps
>> someone has test automation that sets USE_MODULE_DB and nonetheless pro=
bes the
>> exact database name "pl_regression", but I'm not too worried.  The orig=
inal
>> rationale for USE_MODULE_DB, in commit ad69bd0, was to facilitate pg_up=
grade
>> testing.  Folks using "make installcheck-world" to populate a cluster f=
or
>> pg_upgrade testing will see additional test coverage, which may cause
>> additional failures.  I'm fine with that, too.

> +1 for all of that.

I haven't tested the patch, but also +1 for the idea.

			regards, tom lane