Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gW55J-0001l2-Jv for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Dec 2018 19:49:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gW55H-0005WC-Il for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Dec 2018 19:49:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gW55H-0005W5-CE for pgsql-hackers@lists.postgresql.org; Sun, 09 Dec 2018 19:49:47 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gW558-0003ao-G0 for pgsql-hackers@lists.postgresql.org; Sun, 09 Dec 2018 19:49:44 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wB9JnZ9q030831 for ; Sun, 9 Dec 2018 14:49:35 -0500 From: Tom Lane To: pgsql-hackers@lists.postgresql.org Subject: Why does TupleDescInitBuiltinEntry lack a "default: error" case? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <30829.1544384975.1@sss.pgh.pa.us> Date: Sun, 09 Dec 2018 14:49:35 -0500 Message-ID: <30830.1544384975@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk If the passed-in type OID isn't one of the very short list that TupleDescInitBuiltinEntry supports, it will silently hand back a broken TupleDesc, rather than throwing an error. How can this possibly be considered good code? (So far as I can see, none of the extant callers could hit such an error, but it's still bad code.) regards, tom lane