From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
cc: Andrew Dunstan <andrew@dunslane.net>, Noah Misch <noah@leadboat.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Andres Freund <andres@anarazel.de>, Bruce Momjian <bruce@momjian.us>,
        Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: 
 <CAA4eK1JyWsqOihCk7q+iYs-f6JAvnr2TMBWej8HH9TLOpWTivQ@mail.gmail.com>
References: 
 <CAGECzQTqoGHrePM_pwmhaM+J1XOygYjzFod4sf=PAt7J4A19Mw@mail.gmail.com>
 <2238493.1674572097@sss.pgh.pa.us> <Y9ArogF7c+UgPgq9@momjian.us>
 <20230129010603.GA1677550@rfd.leadboat.com> <Y9groc0Nyy7SOROy@momjian.us>
 <20230202062838.GA1832088@rfd.leadboat.com>
 <1477791.1675320029@sss.pgh.pa.us>
 <764a8f96-58c3-361d-428f-7ef827d62023@enterprisedb.com>
 <20230206212157.axnz62oagvycvcjm@awork3.anarazel.de>
 <2828975.1675719367@sss.pgh.pa.us>
 <20230207044324.GB2017197@rfd.leadboat.com>
 <1932eb97-7361-654e-fca5-817386f28306@dunslane.net>
 <CAA4eK1JyWsqOihCk7q+iYs-f6JAvnr2TMBWej8HH9TLOpWTivQ@mail.gmail.com>
Comments: In-reply-to Amit Kapila <amit.kapila16@gmail.com>
	message dated "Tue, 07 Feb 2023 18:26:43 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3083266.1675783064.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 07 Feb 2023 10:17:44 -0500
Message-ID: <3083267.1675783064@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3083267.1675783064%40sss.pgh.pa.us>
Precedence: bulk

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Tue, Feb 7, 2023 at 5:16 PM Andrew Dunstan <andrew@dunslane.net> wrot=
e:
>> On 2023-02-06 Mo 23:43, Noah Misch wrote:
>>>> Yeah.  I don't think we are seriously considering putting any restric=
tions
>>>> in place on gitmaster

>>> I could have sworn that was exactly what we were discussing, a pre-rec=
eive
>>> hook on gitmaster.

>> That's one idea that's been put forward, but it seems clear that some p=
eople are nervous about it.
>> Maybe a better course would be to continue improving the toolset and ge=
t more people comfortable with using it locally and then talk about integr=
ating it upstream.

> Yeah, that sounds more reasonable to me as well.

+1.  Even if we end up with such a hook, we need to walk before we
can run.  The tooling of which we speak doesn't even exist today,
so it's unlikely to be bug-free, fast, and convenient to use
just two months from now.  Let's have some people use whatever
is proposed for awhile locally, and see what their experience is.

			regards, tom lane