From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Bossart, Nathan" <bossartn@amazon.com>
cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Improving psql's \password command
In-reply-to: <450C0AD1-CF21-4056-A9EE-6201E9763FC9@amazon.com>
References: <747443.1635536754@sss.pgh.pa.us>
 <C2787D93-6871-4D93-9CF3-CD7BB489F47F@amazon.com>
 <765509.1635552418@sss.pgh.pa.us>
 <7BAC8A28-148B-4B03-A345-D68071388300@amazon.com>
 <1553329.1636647111@sss.pgh.pa.us>
 <E0C46CDF-46B2-4388-B53B-96EB2CA0F71E@amazon.com>
 <1847699.1636747076@sss.pgh.pa.us>
 <AEA1BA57-BD21-4237-9859-1C04FE38602B@amazon.com>
 <2141902.1636999964@sss.pgh.pa.us>
 <5EDA38EF-C411-4C7D-A9BC-10B1D4584E5E@amazon.com>
 <2152988.1637010233@sss.pgh.pa.us>
 <E4840C66-2FD5-4A0B-8CC9-A09F8B9126B7@amazon.com>
 <2850852.1637194468@sss.pgh.pa.us>
 <450C0AD1-CF21-4056-A9EE-6201E9763FC9@amazon.com>
Comments: In-reply-to "Bossart, Nathan" <bossartn@amazon.com>
	message dated "Fri, 19 Nov 2021 00:41:30 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3085403.1637342157.1@sss.pgh.pa.us>
Date: Fri, 19 Nov 2021 12:15:57 -0500
Message-ID: <3085404.1637342157@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3085404.1637342157%40sss.pgh.pa.us>
Precedence: bulk

"Bossart, Nathan" <bossartn@amazon.com> writes:
> Okay, here is an attempt at adding control-C support for \prompt and
> \connect.  It was reasonably straightforward.  I did have to teach
> simple_prompt_extended() to add a newline after a cancellation when
> "echo" is true.

LGTM, pushed after very minor fooling with the comments.

> I think that's it for psql.  After a quick glance, I didn't see any
> other obvious candidates for control-C support, but I'll look a little
> closer to be sure.

Hmm, initdb's prompt-for-superuser-password might need it.
I think the rest of our frontend programs don't trap SIGINT,
or at least don't do so while requesting user input.

			regards, tom lane