Feedback-ID: i131946ab:Fastmail
Message-ID: <30864847-fab1-268c-60c3-b50be4d9f503@enterprisedb.com>
Date: Fri, 12 May 2023 10:04:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: Add standard collation UNICODE
Content-Language: en-US
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <49417853-7bdd-4b23-a4e9-04c7aff33821@manitou-mail.org>
 <86c5b4c4-0ccf-0996-8fb8-24d348eabe13@enterprisedb.com>
In-Reply-To: <86c5b4c4-0ccf-0996-8fb8-24d348eabe13@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/30864847-fab1-268c-60c3-b50be4d9f503%40enterprisedb.com>
Precedence: bulk

On 08.05.23 17:48, Peter Eisentraut wrote:
> On 27.04.23 13:44, Daniel Verite wrote:
>> This collation has an empty pg_collation.collversion column, instead
>> of being set to the same value as "und-x-icu" to track its version.
> 
>> The original patch implements this as an INSERT in which it would be 
>> easy to
>> fix I guess, but in current HEAD it comes as an entry in
>> include/catalog/pg_collation.dat:
>>
>> { oid => '963',
>>    descr => 'sorts using the Unicode Collation Algorithm with default
>> settings',
>>    collname => 'unicode', collprovider => 'i', collencoding => '-1',
>>    colliculocale => 'und' },
>>
>> Should it be converted back into an INSERT or better left
>> in this file and collversion being updated afterwards?
> 
> How about we do it with an UPDATE command.  We already do this for 
> pg_database in a similar way.  See attached patch.

This has been committed.