From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Fetter <david@fetter.org>
cc: Stephen Frost <sfrost@snowman.net>, Andres Freund <andres@anarazel.de>,
        PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: New EXPLAIN option: ALL
In-reply-to: <20190515060214.GZ28936@fetter.org>
References: <20190507073046.GI28936@fetter.org>
 <20190507154147.l32a3erg4mbycj7u@alap3.anarazel.de>
 <20190507163411.GM28936@fetter.org>
 <20190507164430.a7tig676hjzdnyyd@alap3.anarazel.de>
 <20190507212355.GQ28936@fetter.org>
 <20190507215449.3a4yb5kkoloq7yyw@alap3.anarazel.de>
 <4638.1557266803@sss.pgh.pa.us> <20190507221255.GO6197@tamriel.snowman.net>
 <5221.1557267912@sss.pgh.pa.us> <20190513055112.GA24409@fetter.org>
 <20190515060214.GZ28936@fetter.org>
Comments: In-reply-to David Fetter <david@fetter.org>
	message dated "Wed, 15 May 2019 08:02:14 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30902.1557927151.1@sss.pgh.pa.us>
Date: Wed, 15 May 2019 09:32:31 -0400
Message-ID: <30903.1557927151@sss.pgh.pa.us>
Precedence: bulk

David Fetter <david@fetter.org> writes:
> I hope the patch is a little easier to digest as now attached.

To be blunt, I find 500K worth of changes in the regression test
outputs to be absolutely unacceptable, especially when said changes
are basically worthless from a diagnostic standpoint.  There are
at least two reasons why this won't fly:

* Such a change would be a serious obstacle to back-patching
regression test cases that involve explain output.

* Some buildfarm members use nonstandard settings (notably
force_parallel_mode, but I don't think that's the only one).
We are *not* going to maintain variant output files to try to cope
with all those combinations.  It'd be even more disastrous for
private forks that might have their own affected settings.

I don't know how to make progress towards the original goal
without having a regression-test disaster, but what we have
here is one.

			regards, tom lane