From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Robert Haas <robertmhaas@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Alexander Korotkov <a.korotkov@postgrespro.ru>,
        David Steele <david@pgmasters.net>,
        Ildus Kurbangaliev <i.kurbangaliev@gmail.com>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Andrey Borodin <x4mmm@yandex-team.ru>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: [HACKERS] Custom compression methods (mac+lz4.h)
In-reply-to: <20210320231957.GX11765@telsasoft.com>
References: 
 <CAFiTN-sBH65e4B5kQB5MT8BQOPajkrKvSdKA-07+ra3f2x4vCA@mail.gmail.com>
 <CAFiTN-tErP5x54pvkZP7yLVJhpNBOZcd5TN_k1BDhjYCA9D0VQ@mail.gmail.com>
 <CA+TgmoYRsapWz2vDSQXFAEL_BAMq1aY37avcq9GAB=SUUvFhaw@mail.gmail.com>
 <CAFiTN-t03PqWCaRW1GoWQa0i2NwYw_p=FDj+Kxu_-rY_viALqw@mail.gmail.com>
 <20210319163511.GL11765@telsasoft.com>
 <CA+TgmobuFsxf=nrweN7NYW9VMUV7dX4GYmN966kjeEgXxdxtrg@mail.gmail.com>
 <20210319174425.GM11765@telsasoft.com>
 <CA+TgmobXnzCRf-UOWnjk+OoCT-mzFR867HvoxM2N9uA7+_V-+g@mail.gmail.com>
 <20210320212302.GW11765@telsasoft.com> <301730.1616276227@sss.pgh.pa.us>
 <20210320231957.GX11765@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Sat, 20 Mar 2021 18:19:57 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <309336.1616287493.1@sss.pgh.pa.us>
Date: Sat, 20 Mar 2021 20:44:53 -0400
Message-ID: <309337.1616287493@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/309337.1616287493%40sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> On Sat, Mar 20, 2021 at 05:37:07PM -0400, Tom Lane wrote:
>> Digging around, it looks like the "-I/opt/local/include" bit came
>> from LZ4_CFLAGS, which we then stuck into CFLAGS, but it needed
>> to be put in CPPFLAGS in order to make this test work.

> If it's the same as the issue Andrey reported, then it causes a ./configure
> WARNING, which is resolved by the ac_save hack, which I copied from ICU.

I think probably what we need to do, rather than shove the pkg-config
results willy-nilly into our flags, is to disassemble them like we do
with the same results for xml2.  If you ask me, the way we are handling
ICU flags is a poor precedent that is going to blow up at some point;
the only reason it hasn't is that people aren't building --with-icu that
much yet.

			regards, tom lane