Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gjCK1-0002Ki-9i
	for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Jan 2019 00:11:13 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gjCJz-0008Dn-Ps
	for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Jan 2019 00:11:11 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gjCJz-0008Dg-Ih
	for pgsql-hackers@lists.postgresql.org; Tue, 15 Jan 2019 00:11:11 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gjCJx-0004fq-KC
	for pgsql-hackers@postgresql.org; Tue, 15 Jan 2019 00:11:11 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x0F0Av0T030972;
	Mon, 14 Jan 2019 19:10:57 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
cc: Andres Freund <andres@anarazel.de>, Simon Riggs <simon@2ndquadrant.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Konstantin Knizhnik <k.knizhnik@postgrespro.ru>,
        Michael Paquier <michael.paquier@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Christoph Berg <myon@debian.org>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Surjective functional indexes
In-reply-to: <20190115000639.GA2528@tamriel.snowman.net>
References: 
 <CA+Tgmob_qk-w38Mbp5wCCGH9G8AFpmB0K0aTLujJqHNbBpBNUA@mail.gmail.com>
 <25975.1541618754@sss.pgh.pa.us>
 <20190114223409.3tcvejfhlvbucrv5@alap3.anarazel.de>
 <28044.1547507004@sss.pgh.pa.us>
 <20190114230918.fhp6wktbhg6pjnyw@alap3.anarazel.de>
 <28651.1547507948@sss.pgh.pa.us> <20190114234617.GW2528@tamriel.snowman.net>
 <30007.1547509982@sss.pgh.pa.us>
 <20190114235745.quz72yul3hclx3fu@alap3.anarazel.de>
 <30647.1547510590@sss.pgh.pa.us> <20190115000639.GA2528@tamriel.snowman.net>
Comments: In-reply-to Stephen Frost <sfrost@snowman.net>
	message dated "Mon, 14 Jan 2019 19:06:39 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30970.1547511057.1@sss.pgh.pa.us>
Date: Mon, 14 Jan 2019 19:10:57 -0500
Message-ID: <30971.1547511057@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> What I'm not willing to do is write hacks for pg_upgrade or pg_dump
>> to mask cases where the option has been set on a v11 index.  I judge
>> that it's not worth the trouble.  If someone else disagrees, they
>> can do that work.

> I'd love for there to be a better option beyond "just let people run the
> pg_upgrade and have it fail half-way through"...  Particularly after
> someone's run the pg_upgrade check against the database...

> If there isn't, then I'll write the code to add the check to pg_upgrade.

Go for it.

			regards, tom lane