Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7WVv-000r5E-RW for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 09:35:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u7WVu-004xtY-4D for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 09:35:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7WVt-004xtQ-Q0 for pgsql-hackers@lists.postgresql.org; Wed, 23 Apr 2025 09:35:30 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u7WVr-001ZVD-1u for pgsql-hackers@lists.postgresql.org; Wed, 23 Apr 2025 09:35:30 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id D2B1A2CC23C for ; Wed, 23 Apr 2025 11:35:26 +0200 (CEST) Received: from s979.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id BE2712CC798; Wed, 23 Apr 2025 11:35:26 +0200 (CEST) Received: from s473.loopia.se (unknown [172.22.191.6]) by s979.loopia.se (Postfix) with ESMTP id BB19110BC425; Wed, 23 Apr 2025 11:35:26 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s473.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s981.loopia.se ([172.22.191.6]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with LMTP id NwAJHaXDGgPu; Wed, 23 Apr 2025 11:35:26 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 90.229.0.9 Received: from smtpclient.apple (unknown [90.229.0.9]) (Authenticated sender: daniel@yesql.se) by s981.loopia.se (Postfix) with ESMTPSA id 208F522B179E; Wed, 23 Apr 2025 11:35:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1745400926; bh=lRIZkzgfiyPj2wb5MW7k1+SGpQzQX9meE1OCWu7DfBw=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=IPaupnX55Lp4RjYXsKdHV0oj+ZfmCp3R9ASAJikd85y6rB83qT3ndgOKvXzyg7ckY CFxHSJe8cFqqorN5j7xG1uwENVoMldeTR+NP5AefM+ZEHIetKLJ0HU7VGg3GUUJcyX QwpuJQn+czZfVgZT5U9MTCsK6qWme7Z/d7vdl/ONW7PEuaJBkTsqKE4h3qFI3kCntH Fl8AXJ3v6Pe14L64NmZv56hWaFmWks6/BM/YEImNERKl6UCepsuAnFAo/SrWF5dV4D R8zspNJu//HNnG26C9Cc5/MLuUKD5GZB7man6SbM/Tw/nSTvybss1IWIK/FYmbOhlr 64j3F71ReTAVg== Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Subject: Re: jsonapi: scary new warnings with LTO enabled From: Daniel Gustafsson In-Reply-To: Date: Wed, 23 Apr 2025 11:35:15 +0200 Cc: Tom Lane , PostgreSQL Developers Content-Transfer-Encoding: quoted-printable Message-Id: <30D7779C-8EE0-48BC-B27C-E7389880F713@yesql.se> References: <2074634.1744839761@sss.pgh.pa.us> <0A3CF5C4-9947-42E3-89A9-34FCF7BA95BA@yesql.se> <2078511.1744841564@sss.pgh.pa.us> <2084687.1744844690@sss.pgh.pa.us> <2087556.1744846124@sss.pgh.pa.us> <0A596D8B-24F3-408F-B89B-B42014B00A05@yesql.se> <2202326.1744903233@sss.pgh.pa.us> <25801148-284F-41F9-A279-A4CF92623C77@yesql.se> <102E1997-FB99-4091-926C-9A8BB3EA168E@yesql.se> <0C92C876-09A3-483C-82C5-E26F0C1B34B5@yesql.se> To: Jacob Champion X-Mailer: Apple Mail (2.3776.700.51.11.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 23 Apr 2025, at 02:01, Jacob Champion = wrote: > On Tue, Apr 22, 2025 at 3:10=E2=80=AFAM Daniel Gustafsson = wrote: >> The attached >> v3 allocates via the JSON api, no specific error handling should be = required as >> it's already handled today. >=20 > pgindent shows one whitespace change on my machine (comment > indentation), but other than that, LGTM! Fuzzers are happy too. Thanks for confirming, I've pushed this now. -- Daniel Gustafsson