Message-ID: <30ecef6e-0bbc-c5c3-5cf6-37c2001e4df7@gmail.com>
Date: Tue, 16 May 2023 08:10:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.0
Subject: Re: Introduce WAIT_EVENT_EXTENSION and WAIT_EVENT_BUFFER_PIN
To: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <c6f35117-4b20-4c78-1df5-d3056010dcf5@gmail.com>
 <20230515182956.5lavflljhpgpokxc@awork3.anarazel.de>
 <ZGKynuIpQp1G8Bec@paquier.xyz>
 <20230516001716.iy7no2q77vwdt5w2@awork3.anarazel.de>
 <ZGLQnikZoxsqj2dl@paquier.xyz>
 <20230516010102.jwmsuaoynz6zfqmn@awork3.anarazel.de>
 <ZGMRMrrz02v8MGTE@paquier.xyz>
Content-Language: en-US
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZGMRMrrz02v8MGTE@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/30ecef6e-0bbc-c5c3-5cf6-37c2001e4df7%40gmail.com>
Precedence: bulk

Hi,

On 5/16/23 7:14 AM, Michael Paquier wrote:
> On Mon, May 15, 2023 at 06:01:02PM -0700, Andres Freund wrote:
>> On 2023-05-16 09:38:54 +0900, Michael Paquier wrote:
>>> On Mon, May 15, 2023 at 05:17:16PM -0700, Andres Freund wrote:

> These are the two things refactored in the patch, explaining the what.
> The reason behind the why is to make the script in charge of
> generating all these structures and functions consistent for all the
> wait event classes, simply.  Treating all the wait event classes
> together eases greatly the generation of the documentation, so that it
> is possible to enforce an ordering of the tables of each class used to
> list each wait event type attached to them.

Right, it does "fix" the ordering issue (for BufferPin and Extension)
that I've described in the patch introduction in [1]:

"
   so that PG_WAIT_LWLOCK, PG_WAIT_LOCK, PG_WAIT_BUFFER_PIN and PG_WAIT_EXTENSION are not autogenerated.


This result to having the wait event part of the documentation "monitoring-stats" not ordered as compared to the "Wait Event Types" Table.
.
.
.
"

Thanks Michael for having provided this detailed explanation (my patch
introduction clearly was missing some context as Andres pointed out).

[1]: https://www.postgresql.org/message-id/77a86b3a-c4a8-5f5d-69b9-d70bbf2e9b98%40gmail.com

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com