Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vtrlb-001Lxp-1K for pgsql-hackers@arkaria.postgresql.org; Sat, 21 Feb 2026 18:31:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vtrlZ-00AQvB-39 for pgsql-hackers@arkaria.postgresql.org; Sat, 21 Feb 2026 18:31:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vtrlZ-00AQv3-2F for pgsql-hackers@lists.postgresql.org; Sat, 21 Feb 2026 18:31:45 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vtrlW-00000000bG7-2jlG for pgsql-hackers@postgresql.org; Sat, 21 Feb 2026 18:31:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 61LIVPix3109541; Sat, 21 Feb 2026 13:31:25 -0500 From: Tom Lane To: Peter Eisentraut cc: pgsql-hackers , Heikki Linnakangas , Andres Freund Subject: Re: consider -Wmissing-variable-declarations In-reply-to: <972b0257-00fe-4758-a01b-94918ea34ea6@eisentraut.org> References: <69d9824f-00ea-49b6-b68d-96f0806ec454@iki.fi> <5cf9f601-a9e7-48ed-a007-714209e9779f@eisentraut.org> <20240618150238.hm6tr4prhe7porhq@awork3.anarazel.de> <6070f0ee-176f-4e78-9324-3bbb70a191f9@eisentraut.org> <228700.1722717983@sss.pgh.pa.us> <972b0257-00fe-4758-a01b-94918ea34ea6@eisentraut.org> Comments: In-reply-to Peter Eisentraut message dated "Mon, 05 Aug 2024 07:40:39 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3109539.1771698685.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 21 Feb 2026 13:31:25 -0500 Message-ID: <3109540.1771698685@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > On 03.08.24 22:46, Tom Lane wrote: >> Various buildfarm animals are complaining about >> g++: error: unrecognized command line option "-Wmissing-variable-declar= ations"; did you mean "-Wmissing-declarations"? >> It looks like we are passing CFLAGS not CXXFLAGS to this particular >> g++ invocation. > Changing this seems to have done the trick. I noticed that relatively-new BF animal siren has been failing build in the pre-v18 branches, with symptoms very much like the above: g++ -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-stateme= nt -Werror=3Dvla -Werror=3Dunguarded-availability-new -Wendif-labels -Wmis= sing-format-attribute -Wcast-function-type -Wformat-security -fno-strict-a= liasing -fwrapv -fexcess-precision=3Dstandard -Wno-unused-command-line-arg= ument -Wno-compound-token-split-by-macro -Wno-cast-function-type-strict -g= -O2 -Wno-deprecated-declarations -fPIC -fvisibility=3Dhidden -shared -o = llvmjit.so llvmjit.o llvmjit_error.o llvmjit_inline.o llvmjit_wrap.o Sect= ionMemoryManager.o llvmjit_deform.o llvmjit_expr.o -L../../../../src/port = -L../../../../src/common -Wl,--as-needed -Wl,-rpath,'/home/linux1/20-si= ren/buildroot/REL_17_STABLE/inst/lib',--enable-new-dtags -fvisibility=3Dh= idden -L/usr/lib64 -lLLVM = g++: error: unrecognized command line option "-Wcast-function-type"; did y= ou mean "-Wbad-function-cast"? Evidently this is because 365b5a345 was not back-patched, so we're passing CFLAGS selected for clang to g++. I certainly wouldn't suggest that this is worth breaking release freeze for, but I think we should back-patch once the freeze is over. regards, tom lane