Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eWZyN-0007mK-Q4
	for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jan 2018 03:44:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eWZyN-0001pV-Ca
	for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jan 2018 03:44:11 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eWZyN-0001pM-6K
	for pgsql-hackers@lists.postgresql.org; Wed, 03 Jan 2018 03:44:11 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eWZyJ-0002M1-DX
	for pgsql-hackers@lists.postgresql.org; Wed, 03 Jan 2018 03:44:10 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w033i4ua031123
	for <pgsql-hackers@lists.postgresql.org>; Tue, 2 Jan 2018 22:44:04 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: copy_file_range is now a Linux kernel call
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31121.1514951044.1@sss.pgh.pa.us>
Date: Tue, 02 Jan 2018 22:44:04 -0500
Message-ID: <31122.1514951044@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Buildfarm member caiman just came back online after some time AWOL, and
it's not happy.  The problem evidently is that pg_rewind's copy_file_range
function conflicts with a recently added Linux system call:

http://man7.org/linux/man-pages/man2/copy_file_range.2.html

Looks like we'd better rename our function.  Anybody have an idea
more creative than "pg_copy_file_range"?

(At some point somebody might want to think about fixing this function
so it can make use of the kernel call when available.  But that's more
work than I care to do right now, and certainly more change than I'd want
to back-patch.)

			regards, tom lane