From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Heikki Linnakangas <hlinnaka@iki.fi>, Peter Geoghegan <pg@bowt.ie>,
        David Rowley <dgrowleyml@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: On disable_cost
In-reply-to: 
 <CA+TgmoYiWfNq-oByseKphKn+GWZhL55PwOtSZ87NBE1CVYX7GQ@mail.gmail.com>
References: 
 <CAO0i4_SSPV9TVxbbTRVLOnCyewopcc147fBZy=f2ABk15eHS+g@mail.gmail.com>
 <29821.1572706653@sss.pgh.pa.us>
 <CA+TgmobVH2zMh1ydAHdZzVYxbK-MNrs_R0hTOZbp=gu2abydaA@mail.gmail.com>
 <CAApHDvoREwVZMzu6uNJDvq-p4G6kL69xkSZwjp4c4rdKpqQmmg@mail.gmail.com>
 <CA+TgmoZ7LOTtQgWmEgSUSnVkBiiOyJ5SMQAqCvpJsPr7baTfzw@mail.gmail.com>
 <CAH2-Wzn7t3KZEwDwMFrXzpZKKyKARtpMxmjvUvjOjVRpyQh-Fw@mail.gmail.com>
 <CA+TgmoYUQq3C8Uo-YdDapo2vv84+XqsVi3J2R1RFGC0rf-bkgA@mail.gmail.com>
 <CA+Tgmoaow5wsubUvbn3GUosL6-opRG1Do5p8Q1Dj--OudUTWJQ@mail.gmail.com>
 <CA+TgmoY7kBhu1ykintHQd-NmpFS=TqmuH=gcn9ZQ-Y5OSyH+8w@mail.gmail.com>
 <591b3596-2ea0-4b8e-99c6-fad0ef2801f5@iki.fi>
 <CA+TgmoYiWfNq-oByseKphKn+GWZhL55PwOtSZ87NBE1CVYX7GQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Tue, 02 Jul 2024 13:24:44 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3114836.1719942038.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 02 Jul 2024 13:40:38 -0400
Message-ID: <3114837.1719942038@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3114837.1719942038%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Jul 2, 2024 at 10:57=E2=80=AFAM Heikki Linnakangas <hlinnaka@iki=
.fi> wrote:
>> I fear this will break people's applications, if they are currently
>> forcing a sequential scan with "set enable_indexscan=3Doff". Now they w=
ill
>> need to do "set enable_indexscan=3Doff; set enable_indexonlyscan=3Doff"=
 for
>> the same effect. Maybe it's acceptable, disabling sequential scans to
>> force an index scan is much more common than the other way round.

> But I don't think one can have a GUC called enable_indexscan and
> another GUC called enable_indexonlyscan and argue that it's OK for the
> former one to affect both kinds of scans. That's extremely confusing
> and, well, just plain wrong.

FWIW, I disagree completely.  I think it's entirely natural to
consider bitmap index scans to be a subset of index scans, so that
enable_indexscan should affect both.  I admit that the current set
of GUCs doesn't let you force a bitmap scan over a plain one, but
I can't recall many people complaining about that.  I don't follow
the argument that this definition is somehow unmaintainable, either.

>> Could we cram it into the "cost=3D... rows=3D..." part? And perhaps a m=
arker
>> that a node was disabled would be more user friendly than showing the
>> cumulative count? Something like:

> The problem is that we'd have to derive that.

The other problem is it'd break an awful lot of client code that knows
the format of those lines.  (Sure, by now all such code should have
been rewritten to look at JSON or other more machine-friendly output
formats ... but since we haven't even done that in our own regression
tests, we should know better than to assume other people have done it.)

I'm not really convinced that we need to show anything about this.

			regards, tom lane