Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8oay-0005eV-Tx for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Mar 2019 16:06:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h8oax-0001Qr-O7 for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Mar 2019 16:06:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8oax-0001Qk-DL for pgsql-hackers@lists.postgresql.org; Tue, 26 Mar 2019 16:06:35 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8oau-00058Q-1M for pgsql-hackers@postgresql.org; Tue, 26 Mar 2019 16:06:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x2QG6FWj031187; Tue, 26 Mar 2019 12:06:16 -0400 From: Tom Lane To: Amit Langote cc: Imai Yoshikazu , "jesper.pedersen@redhat.com" , "Imai, Yoshikazu" , "'Amit Langote'" , David Rowley , Alvaro Herrera , Robert Haas , Justin Pryzby , Pg Hackers Subject: Re: speeding up planning with partitions In-reply-to: <19f54c17-1619-b228-10e5-ca343be6a4e8@lab.ntt.co.jp> References: <0F97FA9ABBDBE54F91744A9B37151A5129DD55@g01jpexmbkw24> <256b9c87-b687-6f51-6274-19ae5743aef6@lab.ntt.co.jp> <0F97FA9ABBDBE54F91744A9B37151A5129E604@g01jpexmbkw24> <9feacaf6-ddb3-96dd-5b98-df5e927b1439@lab.ntt.co.jp> <0F97FA9ABBDBE54F91744A9B37151A512B3279@g01jpexmbkw24> <0c90ce90-b010-4791-41c0-a0df34f99ffa@lab.ntt.co.jp> <0F97FA9ABBDBE54F91744A9B37151A512B3528@g01jpexmbkw24> <0F97FA9ABBDBE54F91744A9B37151A512B359C@g01jpexmbkw24> <72094fc9-3232-0fc7-b7cd-42e1c73d5aee@lab.ntt.co.jp> <0F97FA9ABBDBE54F91744A9B37151A512B45CD@g01jpexmbkw24> <53a80692-c68d-5e11-1014-6441b6e8ca5a@redhat.com> <20519.1553288822@sss.pgh.pa.us> <19f54c17-1619-b228-10e5-ca343be6a4e8@lab! .ntt.co.jp> Comments: In-reply-to Amit Langote message dated "Mon, 25 Mar 2019 20:34:45 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <31185.1553616375.1@sss.pgh.pa.us> Date: Tue, 26 Mar 2019 12:06:15 -0400 Message-ID: <31186.1553616375@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Amit Langote writes: > 0002 is a new patch to get rid of the duplicate RTE and PlanRowMark that's > created for partitioned parent table, as it's pointless. I was planning > to propose it later, but decided to post it now if we're modifying the > nearby code anyway. Good idea, but it needs a bit more work on nearby comments, and the logic in expand_single_inheritance_child could be simplified, and you evidently didn't try check-world because the RTE-removal causes cosmetic changes in postgres_fdw.out. I fixed that up and pushed this part. regards, tom lane