From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <jcnaylor@gmail.com>
cc: Stas Kelvich <s.kelvich@postgrespro.ru>, andreas@proxel.se,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        David Fetter <david@fetter.org>
Subject: Re: unused_oids script is broken with bsd sed
In-reply-to: 
 <CAJVSVGVrzzxzVkqYb-=UyqAJRVn1rCx8a2pAYXPLw+6JBg4EZA@mail.gmail.com>
References: <37D774E4-FE1F-437E-B3D2-593F314B7505@postgrespro.ru>
 <34a54c54-9132-1254-2bc3-d3489fb79728@2ndQuadrant.com>
 <4473.1524665917@sss.pgh.pa.us>
 <4DE444D1-DDE9-460F-AC2F-EB1B73D94A2D@postgrespro.ru>
 <CAJVSVGU2w6rvTXghDe7-Y3x9Ca0833VmnC3HpaYKGLw4xznpJA@mail.gmail.com>
 <26728623-7783-4103-9BED-08D443C1729F@postgrespro.ru>
 <CAJVSVGU0cPPwMhCfVz5PvpTDrjZzeT=0QHUhMbg=MjaMO_Gr+A@mail.gmail.com>
 <19973.1524686883@sss.pgh.pa.us>
 <CAJVSVGVrzzxzVkqYb-=UyqAJRVn1rCx8a2pAYXPLw+6JBg4EZA@mail.gmail.com>
Comments: In-reply-to John Naylor <jcnaylor@gmail.com>
	message dated "Thu, 26 Apr 2018 18:37:46 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31237.1524756550.1@sss.pgh.pa.us>
Date: Thu, 26 Apr 2018 11:29:10 -0400
Message-ID: <31238.1524756550@sss.pgh.pa.us>
Precedence: bulk

John Naylor <jcnaylor@gmail.com> writes:
> On 4/26/18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I notice that duplicate_oids is now a good factor of 10 slower than it was
>> before (~0.04 sec to ~0.4 sec, on my machine).  While this doesn't seem
>> like a problem for manual use, it seems annoying as part of the standard
>> build process, especially on slower buildfarm critters.

> If you're concerned about build speed, I think the generated *_d.h
> headers cause a lot more files to be rebuilt than before. I'll think
> about how to recover that.

Personally, I use ccache which doesn't seem to care too much, but I agree
than in some usages, extra touches of headers would be costly.  Perhaps
it's worth adding logic to avoid overwriting an existing output file
unless it changed?  I'm not sure; that would cost something too.

> -removes duplicate_oids (not sure if you intended this, but since
> unused_oids has already been committed to report duplicates, we may as
> well standardize on that) and cleans up after that fact

I don't think anyone's asked for duplicate_oids to be removed altogether,
and I'm afraid that doing so would break existing workflows.  For that
matter, now that I think about it, changing the behavior of unused_oids
as we did yesterday was ill-considered as well, so I undid that part.

I've pushed the current-directory-independence change by itself so that
we can see if any buildfarm members think it's problematic.  (They'll
still be testing duplicate_oids, as things stand.)  Once we have some
confirmation on the FindBin stuff actually being portable, I'll push
the changes to make genbki do duplicate checks and remove duplicate_oids
from the build sequence.

			regards, tom lane