From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        Andrew Gierth <andrew@tao11.riddles.org.uk>,
        Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru>
Subject: Re: Performance improvements for src/port/snprintf.c
In-reply-to: <20181005165819.h7gdzcbwhnhofq2b@alap3.anarazel.de>
References: <28321.1538585692@sss.pgh.pa.us>
 <20181003170043.thdyezozi343dkuc@alap3.anarazel.de>
 <2132.1538587869@sss.pgh.pa.us>
 <20181003173639.tncawup2nnkp7vbv@alap3.anarazel.de>
 <2435.1538588403@sss.pgh.pa.us>
 <20181003174513.wxjxfj7eepytnlqa@alap3.anarazel.de>
 <3316.1538589695@sss.pgh.pa.us>
 <20181003183552.xaams6fau3i7oybj@alap3.anarazel.de>
 <6797.1538592539@sss.pgh.pa.us> <30726.1538754899@sss.pgh.pa.us>
 <20181005165819.h7gdzcbwhnhofq2b@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 05 Oct 2018 09:58:19 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31291.1538759432.1@sss.pgh.pa.us>
Date: Fri, 05 Oct 2018 13:10:32 -0400
Message-ID: <31292.1538759432@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2018-10-05 11:54:59 -0400, Tom Lane wrote:
>> I really think that what we ought to do is apply the float[48]out hack
>> I showed in <30551.1538517271@sss.pgh.pa.us> and call it good, at least
>> till such time as somebody wants to propose a full-on reimplementation of
>> float output.  I don't want to buy back into having platform dependencies
>> in this area after having just expended a lot of sweat to get rid of them.

> I'm not convinced. Because of some hypothetical platform that may
> introduce strfromd() in a broken/slower manner, but where sprintf() is
> correct, we should not do the minimal work to alleviate an actual
> performance bottleneck in a trivial manner on linux? Our most widely
> used platform?  If we find a platform where it's borked, we could just
> add a small hack into their platform template file.

If it were a significant performance improvement, I'd be okay with that
conclusion, but my measurements say that it's not.  The extra complication
is not free, and in my judgement it's not worth it.

We certainly do need to buy back the performance we lost in float[48]out,
but the hack I suggested does so --- on all platforms, not only Linux.

			regards, tom lane