From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Michael Paquier <michael@paquier.xyz>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        pgsql-hackers@postgresql.org
Subject: Re: pg_upgrade test writes to source directory
In-reply-to: <20220528195949.tte5fukfr2z6xhrr@alap3.anarazel.de>
References: <f80ace33-11fb-1cd3-20f8-98f51d151088@enterprisedb.com>
 <Yo3Z5JzHXn7sIe9N@paquier.xyz>
 <b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com>
 <Yo/mWGJjCHOH3eB1@paquier.xyz> <20220526205218.GC19626@telsasoft.com>
 <Yo/5MlXbwY4UhMnm@paquier.xyz> <2464542.1653603596@sss.pgh.pa.us>
 <YpAMBqPrusng47e0@paquier.xyz> <2480063.1653609068@sss.pgh.pa.us>
 <YpAV1y8CUXGGkPJQ@paquier.xyz>
 <20220528195949.tte5fukfr2z6xhrr@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 28 May 2022 12:59:49 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3131726.1653768841.1@sss.pgh.pa.us>
Date: Sat, 28 May 2022 16:14:01 -0400
Message-ID: <3131727.1653768841@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3131727.1653768841%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I suspect there might be a bit more polish might be needed - that's why I
> hadn't proposed the commit on its own yet.

Yeah, I'd noticed the obsoleted comments too, but not bothered to complain
since that was just WIP and not an officially proposed patch.  I'll be
happy to review if you want to put up a full patch.

> I was also wondering about
> proposing a different split (test data, test logs).

Might be too invasive for back-patch.

			regards, tom lane