Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1todJW-00DMPg-MI
	for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Mar 2025 07:00:39 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1todJW-00GvKI-Py
	for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Mar 2025 07:00:37 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1todJW-00GvGz-G4
	for pgsql-hackers@lists.postgresql.org; Sun, 02 Mar 2025 07:00:37 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1todJR-000UJN-1z
	for pgsql-hackers@postgresql.org;
	Sun, 02 Mar 2025 07:00:36 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 52270XQY3131836;
	Sun, 2 Mar 2025 02:00:33 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Gurjeet Singh <gurjeet@singh.im>
cc: Postgres Hackers <pgsql-hackers@postgresql.org>
Subject: Re: lwlocknames.h beautification attempt
In-reply-to: <CABwTF4VK4sFjdm9kE9CcWW1p2MGDBW4qhA_Sibcy=9fj+oP8bg@mail.gmail.com>
References: <CABwTF4VxfwDtRV-H22_XK4XeDogaV-Vaobu+af5U=8ZAZn9ZZQ@mail.gmail.com> <3128012.1740896767@sss.pgh.pa.us> <CABwTF4VK4sFjdm9kE9CcWW1p2MGDBW4qhA_Sibcy=9fj+oP8bg@mail.gmail.com>
Comments: In-reply-to Gurjeet Singh <gurjeet@singh.im>
	message dated "Sat, 01 Mar 2025 22:35:12 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3131834.1740898833.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Sun, 02 Mar 2025 02:00:33 -0500
Message-ID: <3131835.1740898833@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/3131835.1740898833%40sss.pgh.pa.us>
Precedence: bulk

Gurjeet Singh <gurjeet@singh.im> writes:
> On Sat, Mar 1, 2025 at 10:26 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This looks reasonably in line with project style ...

> Should I create a commitfest entry for this patch, or is it
> uncontroversial enough and small enough to not warrant that?

The controversy would be more about whether it's worth bothering
with.  In the past we've taken some care to ensure that generated
files would pass pgindent's ideas of correct formatting, but
not more than that.  AFAICT from some quick tests, pgindent has
no opinions about layout of #define lines.

			regards, tom lane