From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Ronan Dunklau <ronan.dunklau@aiven.io>,
 pgsql-hackers@lists.postgresql.org,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
In-reply-to: <Zyq9fXnmc5YiXik_@paquier.xyz>
References: <3395418.1618352794@sss.pgh.pa.us>
 <3316564.aeNJFYEL58@aivenlaptop> <2650823.1730736601@sss.pgh.pa.us>
 <1901969.tdWV9SEqCh@aivenlaptop> <Zyq9fXnmc5YiXik_@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 06 Nov 2024 09:51:09 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3133932.1730855116.1@sss.pgh.pa.us>
Date: Tue, 05 Nov 2024 20:05:16 -0500
Message-ID: <3133933.1730855116@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3133933.1730855116%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> I was wondering what was going on here, and this patch comes down to
> switching all these definitions from that:
> CREATE FUNCTION lo_oid(lo) RETURNS pg_catalog.oid AS
> 'SELECT $1::pg_catalog.oid' LANGUAGE SQL STRICT IMMUTABLE PARALLEL SAFE;

> To that:
> +CREATE OR REPLACE FUNCTION lo_oid(lo) RETURNS pg_catalog.oid
> +LANGUAGE SQL STRICT IMMUTABLE PARALLEL SAFE
> +RETURN (SELECT $1::pg_catalog.oid);

Right.

> This makes the executions more robust run-time search_path checks.  Is
> that something that should be considered for a backpatch, actually?

No, I don't think so.  For one thing, it would not help existing
installations unless they issue "ALTER EXTENSION UPDATE", which
people are not likely to do in a minor update.  But also, we don't
know of live attacks against these functions with their current
definitions, so I don't think this is urgent.

			regards, tom lane