Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkrFL-0003eQ-IQ for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Apr 2023 18:55:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkrFK-0003ba-8m for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Apr 2023 18:55:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkrFJ-0003bQ-Vg for pgsql-hackers@lists.postgresql.org; Fri, 07 Apr 2023 18:55:37 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pkrFH-001Ugb-Df for pgsql-hackers@lists.postgresql.org; Fri, 07 Apr 2023 18:55:37 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 337ItScA3135274; Fri, 7 Apr 2023 14:55:28 -0400 From: Tom Lane To: Tomas Vondra cc: Dag Lem , Andres Freund , Alvaro Herrera , Paul Ramsey , PostgreSQL Hackers Subject: Re: daitch_mokotoff module In-reply-to: <037c6b65-019e-7e4b-4fd0-77973ea75a9f@enterprisedb.com> References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql> <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com> <20230211025830.twigy3l65bc27cyw@awork3.anarazel.de> <037c6b65-019e-7e4b-4fd0-77973ea75a9f@enterprisedb.com> Comments: In-reply-to Tomas Vondra message dated "Mon, 03 Apr 2023 16:45:39 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3135272.1680893728.1@sss.pgh.pa.us> Date: Fri, 07 Apr 2023 14:55:28 -0400 Message-ID: <3135273.1680893728@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Tomas Vondra writes: > Hi, I think from the technical point of view it's sound and ready for > commit. The patch stalled on the copyright/credit stuff, which is > somewhat separate and mostly non-technical aspect of patches. Sorry for > that, I'm sure it's annoying/frustrating :-( > I see the current patch has two simple lines: > * This module was originally sponsored by Finance Norway / > * Trafikkforsikringsforeningen, and implemented by Dag Lem > Any objections to this level of attribution in commnents? That seems fine to me. I'll check this over and see if I can get it pushed today. regards, tom lane