From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Justin Pryzby <pryzby@telsasoft.com>, David Steele <david@pgmasters.net>,
        Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
        Stephen Frost <sfrost@snowman.net>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Suraj Kharage <suraj.kharage@enterprisedb.com>,
        tushar <tushar.ahuja@enterprisedb.com>,
        Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
        Rushabh Lathia <rushabh.lathia@gmail.com>,
        Tels <nospam-pg-abuse@bloodgate.com>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
        vignesh C <vignesh21@gmail.com>
Subject: Re: backup manifests
In-reply-to: <20200403212445.GB12283@telsasoft.com>
References: 
 <CA+TgmobV+kW5cBCa8_LGvytdOH71gnpqDsmKBR7bghEFgR7Y1w@mail.gmail.com>
 <CA+Tgmob+xDcvEUTznkvianyJzKK8nUM6bWfkrnZQkL-XEa3NEA@mail.gmail.com>
 <20200402172318.3kvfrrewxmemzpia@alap3.anarazel.de>
 <CA+Tgmoa2_8Ti9xez8wEH7Z_RJQv=cwPC=MeqUXcdVW=5-uMCig@mail.gmail.com>
 <20200402182346.6iffoadxu2hsbi2s@alap3.anarazel.de>
 <CA+TgmoboTL8cBt_P5Jx6RjL=Hk3Y8PbpGsh9KcH_MZuswVqdYA@mail.gmail.com>
 <CA+TgmoaGoQM74CMJhqg3_M7osWgkT2xSxo9aGVu9E4Nt+8Z4sg@mail.gmail.com>
 <20200402194750.7ze74b4t6b6o4cui@alap3.anarazel.de>
 <e3101c23-26b7-6fa2-14a8-af24c96602b5@pgmasters.net>
 <CA+TgmoaKhxPr0FWsEiZoXpMER44pMJ28L-Z7wcRrOKoGFwjiUQ@mail.gmail.com>
 <20200403212445.GB12283@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Fri, 03 Apr 2020 16:24:45 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31358.1585959529.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 03 Apr 2020 20:18:49 -0400
Message-ID: <31359.1585959529@sss.pgh.pa.us>
Precedence: bulk

BTW, some of the buildfarm is showing a simpler portability problem:
they think you were too cavalier about the difference between time_t
and pg_time_t.  (On a platform with 32-bit time_t, that's an actual
bug, probably.)  lapwing is actually failing:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dlapwing&dt=3D202=
0-04-03%2021%3A41%3A49

ccache gcc -std=3Dgnu99 -Wall -Wmissing-prototypes -Wpointer-arith -Wdecla=
ration-after-statement -Werror=3Dvla -Wendif-labels -Wmissing-format-attri=
bute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=3Ds=
tandard -g -O2 -Werror -I. -I. -I../../../src/include  -DENFORCE_REGRESSIO=
N_TEST_NAME_RESTRICTIONS -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/incl=
ude/et  -c -o basebackup.o basebackup.c
basebackup.c: In function 'AddFileToManifest':
basebackup.c:1199:10: error: passing argument 1 of 'pg_gmtime' from incomp=
atible pointer type [-Werror]
In file included from ../../../src/include/access/xlog_internal.h:26:0,
                 from basebackup.c:20:
../../../src/include/pgtime.h:49:22: note: expected 'const pg_time_t *' bu=
t argument is of type 'time_t *'
cc1: all warnings being treated as errors
make[3]: *** [basebackup.o] Error 1

but some others are showing it as a warning.

I suppose that judicious s/time_t/pg_time_t/ would fix this.

			regards, tom lane