From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
        Robert Haas <robertmhaas@gmail.com>, amul sul <sulamul@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Bug in pg_dump --table and --exclude-table for declarative
 partition table handling.
In-reply-to: 
 <CAOgcT0PPxRsHMMhB0cZY=fC=O9y69tptH5PioHx64DPc9t14zA@mail.gmail.com>
References: 
 <CAAJ_b94bXL28PqXACEZfWQA0qfmmKrjB3FDhgQOOzFDyYzDVtA@mail.gmail.com>
 <CAOgcT0N3JHJKcasd24_Zk-2rpf2Sk4LtTCVBgYoebPysTq-z8g@mail.gmail.com>
 <CA+TgmoazyEb9mdL3yJkWRHHtcOFBzZDE_ESgq8iE22gPpdML-w@mail.gmail.com>
 <14125.1494452121@sss.pgh.pa.us>
 <CAFjFpRcVZX7ABrvQ0esbUg2KxyQaASc8HokjNGeg6Sk7boP8iA@mail.gmail.com>
 <CAOgcT0PPxRsHMMhB0cZY=fC=O9y69tptH5PioHx64DPc9t14zA@mail.gmail.com>
Comments: In-reply-to Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
	message dated "Thu, 11 May 2017 18:20:04 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31398.1494507762.1@sss.pgh.pa.us>
Date: Thu, 11 May 2017 09:02:42 -0400
Message-ID: <31399.1494507762@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Jeevan Ladhe <jeevan.ladhe@enterprisedb.com> writes:
> On Thu, May 11, 2017 at 4:47 PM, Ashutosh Bapat <
>> We add PARTITION OF clause for a table which is partition, so if the
>> parent is not present while restoring, the restore is going to fail.

> +1
> But, similarly for inheritance if we dump a child table, it's dump is
> broken as
> of today. When we dump a child table we append "inherits(parenttab)" clause
> at
> the end of the DDL. Later when we try to restore this table on a database
> not
> having the parenttab, the restore fails.
> So, I consider this as a bug.

It sounds exactly what I'd expect.  In particular, given that pg_dump has
worked that way for inherited tables from the beginning, it's hard to see
any must-fix bugs here.

You could argue that it would be better for pg_dump to emit something
like

	CREATE TABLE c (...);
	ALTER TABLE c INHERIT p;

so that if p isn't around, at least c gets created.  And I think it
*would* be better, probably.  But if that isn't a new feature then
I don't know what is.  And partitioning really ought to track the
behavior of inheritance here.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers