From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@lists.postgresql.org,
        Daniel Gustafsson <daniel@yesql.se>
Subject: Re: format of pg_upgrade loadable_libraries warning
In-reply-to: <20191005001524.GB21896@momjian.us>
References: <20191002172337.GC9680@telsasoft.com>
 <20191004213746.GD29227@momjian.us> <20191004224008.GQ11241@telsasoft.com>
 <20191005001524.GB21896@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Fri, 04 Oct 2019 20:15:24 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31404.1570247721.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 04 Oct 2019 23:55:21 -0400
Message-ID: <31405.1570247721@sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> On Fri, Oct  4, 2019 at 05:40:08PM -0500, Justin Pryzby wrote:
>> I would argue to include in 12.1, since 12 is what most everyone will u=
se for
>> upgrades, and patch for .1 will help people upgrading for 11 of the nex=
t 12
>> months.  (But, your patch is more general than mine).

> No, there might be tools that depend on the existing format, and this is
> the first report of confusion I have read.

Translations will also lag behind any such change.  Speaking of which,
it might be a good idea to include some translator: annotations to
help translators understand what context these fragmentary phrases
are used in.  I'd actually say that my biggest concern with these
messages is whether they can translate into something sane.

			regards, tom lane